Skip to content

Optimistic locking for delete scenario with TransactWriteItemsEnhancedRequest #6043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roamariei
Copy link
Contributor

@roamariei roamariei commented Apr 17, 2025

Description

Optimistic locking while using DynamoDbEnhancedClient - DeleteItem with TransactWriteItemsEnhancedRequest

Motivation and Context

#2358

Modifications

  • Modified addDeleteItem method in TransactWriteItemsEnhancedRequest to invoke a new method, generateTransactDeleteItem, which includes an additional parameter: Map<String, AttributeValue> itemMap.
  • Redirected delete operations to an internal method that constructs the version check condition.
  • Added an internal BeforeDelete interface, similar to BeforeWrite, to handle version validation before execution. The implementation of this method was placed in VersionedRecordExtension and called from DeleteItemOperation.

Testing

Added unit tests for ChainExtension, VersionRecordTest and integration tests for delete scenario with matching version and with exception if the version mismatch.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@roamariei roamariei requested a review from a team as a code owner April 17, 2025 14:52
@roamariei roamariei force-pushed the bugifx/optimistic-locking-not-working-for-delete-operation-with-transactWriteItemsEnhancedRequest branch from 9d90f5d to 12779d9 Compare April 17, 2025 17:46
@roamariei roamariei changed the title updated transact delete item flow to check the version for optimistic… Optimistic locking for delete scenario with TransactWriteItemsEnhancedRequest Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant