Skip to content

Codecov report fails CI although the bug with coverage was fixed in #1324 #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trivikr opened this issue Jul 7, 2020 · 5 comments
Closed

Comments

@trivikr
Copy link
Member

trivikr commented Jul 7, 2020

Describe the bug
Codecov shows coverage reduced although the issue with coverage was fixed

SDK version number
master

To Reproduce (observed behavior)
Create a new PR to the repository and see Codecov reports fail the CI

Expected behavior
CodeCov reports are successful, if code doesn't reduce coverage

@trivikr
Copy link
Member Author

trivikr commented Jul 7, 2020

Codecov website shows "Not enough commits found with current parameters" if "last 7 days" is selected
https://codecov.io/gh/aws/aws-sdk-js-v3

Looks like Codecov report is not uploaded on push to master

Screenshot

Screen Shot 2020-07-07 at 9 15 04 AM

@trivikr
Copy link
Member Author

trivikr commented Jul 7, 2020

Manually uploaded coverage reports for master from workspace.
Verified that reports are uploaded for latest commit 4e31b7d at https://codecov.io/gh/aws/aws-sdk-js-v3/branch/master

Screenshot

Screen Shot 2020-07-07 at 9 24 43 AM (2)

Will revisit when new PR is posted, and commit is merged to master

@trivikr
Copy link
Member Author

trivikr commented Jul 7, 2020

The issue was fixed.
Verified in PR #1337 (comment)

@trivikr trivikr closed this as completed Jul 7, 2020
@trivikr
Copy link
Member Author

trivikr commented Jul 7, 2020

ToDo: Verify if commit from PR #1337 appears in https://codecov.io/gh/aws/aws-sdk-js-v3/branch/master after merging to master, and successful build.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant