Skip to content

chore(middleware-retry): move mocks to beforeEach #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 7, 2020

Issue #, if available:
N/A

Description of changes:
move mocks to beforeEach

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1337   +/-   ##
=======================================
  Coverage   77.67%   77.67%           
=======================================
  Files         286      286           
  Lines       11955    11955           
  Branches     2623     2623           
=======================================
  Hits         9286     9286           
  Misses       2669     2669           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e31b7d...0ba50aa. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Jul 7, 2020

ToDo after merge: Verify that codecov history for master is updated after this PR is merged
Details: #1335 (comment)

@trivikr trivikr requested a review from AllanZhengYP July 7, 2020 20:38
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr merged commit 3d89f57 into aws:master Jul 10, 2020
@trivikr trivikr deleted the move-mock-to-beforeEach branch July 10, 2020 17:33
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants