Skip to content

chore: rename maxRetries to maxAttempts #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 5, 2020

Issue #, if available:
To align with naming schema to be used in standard retry strategy (internal JS-1537)

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@trivikr trivikr force-pushed the rename-maxRetries branch from 0816564 to d17a3e5 Compare June 5, 2020 19:51
@aws-sdk-js-automation

This comment has been minimized.

@trivikr trivikr requested a review from AllanZhengYP June 5, 2020 20:43
@trivikr trivikr requested a review from AllanZhengYP June 5, 2020 21:20
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: f9c8f5f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!🚢

@trivikr trivikr merged commit 7dbb571 into aws:master Jun 5, 2020
@trivikr trivikr deleted the rename-maxRetries branch June 5, 2020 21:42
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants