chore: faster build time #1285
Merged
chore: faster build time #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexforsyth
requested review from
trivikr and
AllanZhengYP
and removed request for
trivikr
alexforsyth
commented
Jun 19, 2020
| @@ -73,4 +73,4 @@ | |||
| "lint-staged": { | |||
| "**/*.{ts,js,md,json}": "prettier --write" | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Not sure what happened here, doesnt show up on the diff in vscode
trivikr
approved these changes
Jun 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
+ Coverage 73.04% 73.06% +0.01%
==========================================
Files 287 287
Lines 12730 12736 +6
Branches 2922 2924 +2
==========================================
+ Hits 9299 9305 +6
Misses 3431 3431
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Removed --include-dependency to speed up build time.
Some stats:
Before (clean build, git clean -fxd && yarn)
After (clean build, git clean -fxd && yarn)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.