Skip to content

Conversation

@marcote
Copy link
Contributor

@marcote marcote commented Nov 11, 2016

Fixes #1220

@coveralls
Copy link

coveralls commented Nov 11, 2016

Coverage Status

Coverage remained the same at 88.09% when pulling ad903e8 on marcote:master into 17cd1cc on aws:master.

@chrisradek
Copy link
Contributor

@marcote
Thanks for the PR! Merging.

@chrisradek chrisradek merged commit 9d5881e into aws:master Nov 11, 2016
@blakeembrey
Copy link

@marcote Shouldn't you actually enable noImplicitAny so this won't happen again? See https://github.com/aws/aws-sdk-js/blob/master/ts/tsconfig.json. Here's the config I usually recommend for people writing type definitions - https://github.com/types/guidelines#tsconfigjson.

@maghis
Copy link
Contributor

maghis commented Nov 13, 2016

@blakeembrey see #1224, any other suggestion?

@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow noImplicitAny = true from TypeScript

5 participants