Loosen rack requirement to allow for rack 3 #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2024
Closed
|
@searls Do you have any input to this and does it help unblock you? |
|
Since you are touching the Gemfile anyway, might wanna update the email there - similarly to what we did for other gems: https://github.com/aws/aws-sdk-ruby-record/blob/dc6d97ba295438c262bc0aac4b45ba188686557c/aws-record.gemspec#L7 |
|
@mullermp this should work -- I haven't tried it because I've dropped down to SMTP sending for now |
alextwoods
approved these changes
Jan 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains only part of the work here: https://github.com/aws/aws-sessionstore-dynamodb-ruby/pull/33/files
This unblocks
aws-sdk-railscustomers by loosening requirements to use rack 3.Another major version of this gem should be released to force rack 3, remove locking, and fix any rack 2 -> rack 3 incompatibilities.