Skip to content

Cleanup #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 10, 2020
Merged

Cleanup #202

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4edb4b5
DummySegment and DummySubSegment creation
bhautikpip Feb 13, 2020
0442d84
Revert "DummySegment and DummySubSegment creation"
bhautikpip Feb 13, 2020
a9d172a
Revert "Revert "DummySegment and DummySubSegment creation""
bhautikpip Feb 13, 2020
7b60842
ran gofmt command to remove golint warnings
bhautikpip Feb 13, 2020
ca86dc6
remove redundent declaration
bhautikpip Feb 13, 2020
aae8545
Merge branch 'master' into master
bhautikpip Feb 25, 2020
b22e192
Merge branch 'master' into master
bhautikpip Feb 28, 2020
a6facdd
Added Dummysegment creation logic
bhautikpip Feb 28, 2020
6b620c6
Added reviewdog suggestions
bhautikpip Feb 28, 2020
e6cacdf
modified code based on feedback
bhautikpip Mar 3, 2020
d45311a
Merge branch 'master' into master
bhautikpip Mar 3, 2020
2b75fe2
clean up before release
bhautikpip Mar 9, 2020
37e8712
Merge branch 'master' into cleanup
bhautikpip Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions xray/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,14 +336,6 @@ func TestRoundTripReuseDatarace(t *testing.T) {
}()
}
wg.Wait()

// FIXME: @shogo82148 sometimes fail with context deadline exceeded
// for i := 0; i < n; i++ {
// _, err := td.Recv()
// if !assert.NoError(t, err) {
// return
// }
// }
}

func TestRoundTripReuseTLSDatarace(t *testing.T) {
Expand Down Expand Up @@ -373,14 +365,6 @@ func TestRoundTripReuseTLSDatarace(t *testing.T) {
}()
}
wg.Wait()

// FIXME: @shogo82148 sometimes fail with context deadline exceeded
// for i := 0; i < n; i++ {
// _, err := td.Recv()
// if !assert.NoError(t, err) {
// return
// }
// }
}

func TestRoundTripReuseHTTP2Datarace(t *testing.T) {
Expand Down Expand Up @@ -423,14 +407,6 @@ func TestRoundTripReuseHTTP2Datarace(t *testing.T) {
}()
}
wg.Wait()

// FIXME: @shogo82148 sometimes fail with context deadline exceeded
// for i := 0; i < n; i++ {
// _, err := td.Recv()
// if !assert.NoError(t, err) {
// return
// }
// }
}

// Benchmarks
Expand Down