Skip to content

Removing broken test #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removing broken test #472

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
435a5b8
Removing broken test
Jun 12, 2024
fed0950
Merge branch 'master' into bad_test
wangzlei Jul 8, 2024
64d154e
Merge branch 'master' into bad_test
MLCarey321 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions xray/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,35 +382,6 @@ func TestBadRoundTrip(t *testing.T) {
}
}

func TestBadRoundTripDial(t *testing.T) {
ctx, td := NewTestDaemon()
defer td.Close()

client := Client(nil)

doErr := httpDoTest(ctx, client, http.MethodGet, "http://domain.invalid:8000", nil)
assert.Error(t, doErr)

seg, err := td.Recv()
if !assert.NoError(t, err) {
return
}
var subseg *Segment
if assert.NoError(t, json.Unmarshal(seg.Subsegments[0], &subseg)) {
assert.Contains(t, fmt.Sprintf("%v", doErr), subseg.Cause.Exceptions[0].Message)

// Also ensure that the 'connect' subsegment is closed and showing fault
var connectSeg *Segment
if assert.NoError(t, json.Unmarshal(subseg.Subsegments[0], &connectSeg)) {
assert.Equal(t, "connect", connectSeg.Name)
assert.NotZero(t, connectSeg.EndTime)
assert.False(t, connectSeg.InProgress)
assert.True(t, connectSeg.Fault)
assert.NotEmpty(t, connectSeg.Subsegments)
}
}
}

func TestRoundTripReuseDatarace(t *testing.T) {
ctx, td := NewTestDaemon()
defer td.Close()
Expand Down