Skip to content

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Feb 21, 2025

Issue #, if available:

To correctly upgrade this Go module to v2, there are 2 options:
https://go.dev/wiki/Modules#releasing-modules-v2-or-higher
This PR uses the first method of upgrading to v2.

Description of changes:

Change github.com/aws/aws-xray-sdk-go to github.com/aws/aws-xray-sdk-go/v2 where applicable.
README changes coming later

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jj22ee jj22ee requested a review from a team as a code owner February 21, 2025 20:38
Copy link
Contributor

@yiyuan-he yiyuan-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense to me. What was the method of searching for all the places to update with /v2 suffix? Can we be sure we didn't miss anything?

@jj22ee
Copy link
Contributor Author

jj22ee commented Feb 21, 2025

The v2 change applies to all *.go and go.* files for the github.com/aws/aws-xray-sdk-go string via some "replace all" functions from IDE.
For other files like workflow/README files, I checked which instances of the string that should have v2 appended.

@jj22ee jj22ee merged commit 5fb4d3a into aws:master Feb 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants