Skip to content

Add bash file and modify docker #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 91 commits into
base: master
Choose a base branch
from
Open

Add bash file and modify docker #4773

wants to merge 91 commits into from

Conversation

Yadan-Wei
Copy link
Contributor

@Yadan-Wei Yadan-Wei commented May 1, 2025

GitHub Issue #, if available:

Note:

  • If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

  • All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.

Description

Tests run

With entrypoint and bashrc

  • 2796e98 TF218 Training SageMaker Passed ec2 test(all telemetry code included)
  • 6226baf PT 2.6 Inference Sagemaker passed ec2 tests.
  • 772cb40 PT2.6 Training EC2 passed telemetry test.
  • 8cd0e65 PT2.6 Training Sagemaker passed telemetry test.

Without entrypoint and bashrc

  • bf701c1 ARM64 PT2.6 Inf passed ec2 tests.
  • a487a16 x86 PT2.6 Training passed ec2 tests.
  • a487a16 x86 PT 2.5 Training passed ec2 tests.
  • bde0aa0 x86 TF 218 Training passed ec2 tests.
  • d139d8e x86 TF 218 Inference passed ec2 tests.
  • e1801ee ARM64 TF218 inference passed ec2 tests.

NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"

  • I have run builds/tests on commit for my changes.
Confused on how to run tests? Try using the helper utility...

Assuming your remote is called origin (you can find out more with git remote -v)...

  • Run default builds and tests for a particular buildspec - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp origin

  • Enable specific tests for a buildspec or set of buildspecs - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp origin

  • Restore TOML file when ready to merge

python src/prepare_dlc_dev_environment.py -rcp origin

NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:

Expand
  • sagemaker_remote_tests = true
  • sagemaker_efa_tests = true
  • sagemaker_rc_tests = true

Additionally, please run the sagemaker local tests in at least one revision:

  • sagemaker_local_tests = true

Formatting

DLC image/dockerfile

Builds to Execute

Expand

Fill out the template and click the checkbox of the builds you'd like to execute

Note: Replace with <X.Y> with the major.minor framework version (i.e. 2.2) you would like to start.

  • build_pytorch_training_<X.Y>_sm

  • build_pytorch_training_<X.Y>_ec2

  • build_pytorch_inference_<X.Y>_sm

  • build_pytorch_inference_<X.Y>_ec2

  • build_pytorch_inference_<X.Y>_graviton

  • build_tensorflow_training_<X.Y>_sm

  • build_tensorflow_training_<X.Y>_ec2

  • build_tensorflow_inference_<X.Y>_sm

  • build_tensorflow_inference_<X.Y>_ec2

  • build_tensorflow_inference_<X.Y>_graviton

Additional context

PR Checklist

Expand
  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron/graviton] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • If the PR changes affects SM test, I've modified dlc_developer_config.toml in my PR branch by setting sagemaker_tests = true and efa_tests = true
  • If this PR changes existing code, the change fully backward compatible with pre-existing code. (Non backward-compatible changes need special approval.)
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

NEURON/GRAVITON Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting neuron_mode = true or graviton_mode = true

Benchmark Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting ec2_benchmark_tests = true or sagemaker_benchmark_tests = true

Pytest Marker Checklist

Expand
  • (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Yadan-Wei Yadan-Wei requested review from a team as code owners May 1, 2025 23:17
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added authorized build Reflects file change in build folder pytorch Reflects file change in pytorch folder Size:S Determines the size of the PR src Reflects file change in src folder labels May 1, 2025
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added ec2 Reflects file change in dlc_tests/ec2 folder test Reflects file change in test folder labels May 2, 2025
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added the tensorflow Reflects file change in tensorflow folder label May 13, 2025
junpuf
junpuf previously approved these changes May 20, 2025
@@ -1,5 +1,10 @@
#!/usr/bin/env bash

# telemetry.sh
# Execute telemetry script if it exists, suppress errors
bash /usr/local/bin/bash_telemetry.sh 2>/dev/null || true
Copy link
Contributor

@sallyseok sallyseok May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here and all the other bash entrypoints

if [ -f /usr/local/bin/deep_learning_container.py ] && [ -z "${OPT_OUT_TRACKING}" -o "${OPT_OUT_TRACKING,,}" != "true" ]; then
(
python /usr/local/bin/deep_learning_container.py \
--framework "${FRAMEWORK}" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of having the $ here since we're going to replace it anyways? Is it to make this file more versatile / make it usable on its own not as a template?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I want it usable when passing the environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authorized build Reflects file change in build folder ec2 Reflects file change in dlc_tests/ec2 folder pytorch Reflects file change in pytorch folder Size:S Determines the size of the PR src Reflects file change in src folder tensorflow Reflects file change in tensorflow folder test Reflects file change in test folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants