feat: add per-monitor configuration to selectively disable monitors#50
Merged
Conversation
prasad0896
reviewed
Feb 25, 2026
prasad0896
reviewed
Feb 25, 2026
prasad0896
reviewed
Feb 25, 2026
Contributor
prasad0896
left a comment
There was a problem hiding this comment.
Can we also do either of the two:
a. Add a doc to examples/ to provide an actual example of how monitors can be disabled and all the places that need to be updated.
b. Update readme with instructions on configuring monitors for the agent.
Contributor
|
/ci |
Contributor
|
@prasad0896 roger that! I've dispatched a workflow. 👍 |
Contributor
|
@prasad0896 the workflow that you requested has completed.
|
Contributor
Author
|
The CI is flaky when running on all versions of k8s because of account level limits that cause some clusters timeout while coming up. Going to test on one version only for now and figure out a way to make ci more stable. |
Contributor
Author
|
/ci |
Contributor
Contributor
prasad0896
reviewed
Feb 26, 2026
prasad0896
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
NA
Description of changes:
Adds a configuration layer for selectively disabling NMA monitors via Helm values. Config flows from
values.yaml-> Helm-managed ConfigMap -> volume mount at/etc/nma/config.yaml-> parsed at startup. The per-monitor settings struct is extensible for future fields (e.g., intervals).Example Usage
Testing Done:
Deploy like so:
Logs:
Confirmed that Networking condition is still true:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.