Skip to content

ci: reduce flakiness and optimize resources#65

Merged
shvbsle merged 3 commits into
aws:mainfrom
shvbsle:ci-sanity
Mar 4, 2026
Merged

ci: reduce flakiness and optimize resources#65
shvbsle merged 3 commits into
aws:mainfrom
shvbsle:ci-sanity

Conversation

@shvbsle
Copy link
Copy Markdown
Contributor

@shvbsle shvbsle commented Mar 3, 2026

Issue #, if available:

Flaky runs: workflow

Description of changes:

Reduce e2e cluster from 3 nodes to 1. On a multi-node cluster, only the node running system pods (CoreDNS, etc.) has VPC CNI IPAMD allocations, so /var/run/aws-node/ipam.json doesn't exist on idle nodes. The IPAMD log collector records this as an error in log-capture-errors.log, which assertLogsValid treats as a test failure. A single node runs all system pods and will always have the IPAMD checkpoint file. This also reduces CI compute costs. We don't need 3 nodes to validate NMA behavior.

Testing Done:

  • e2e tests passing on CI with 1-node cluster
  • workflow

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shvbsle
Copy link
Copy Markdown
Contributor Author

shvbsle commented Mar 3, 2026

/ci
+workflow:k8s_versions 1.34

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

@shvbsle roger that! I've dispatched a workflow. 👍

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

@shvbsle the workflow that you requested has completed.

K8s Version Arch Instance Type Result Details
1.34 amd64 t3.medium failure ❌ logs

⚠️ 1/1 version(s) failed

@shvbsle
Copy link
Copy Markdown
Contributor Author

shvbsle commented Mar 3, 2026

Interesting. Log collection succeeded but validation failed. Possibly due to corrupted archives. I'm going to re-run the CI to see if its a flake

@shvbsle
Copy link
Copy Markdown
Contributor Author

shvbsle commented Mar 3, 2026

/ci
+workflow:k8s_versions 1.34

2 similar comments
@shvbsle
Copy link
Copy Markdown
Contributor Author

shvbsle commented Mar 3, 2026

/ci
+workflow:k8s_versions 1.34

@shvbsle
Copy link
Copy Markdown
Contributor Author

shvbsle commented Mar 3, 2026

/ci
+workflow:k8s_versions 1.34

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

@shvbsle roger that! I've dispatched a workflow. 👍

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

@shvbsle the workflow that you requested has completed.

Result: failure ❌

@shvbsle
Copy link
Copy Markdown
Contributor Author

shvbsle commented Mar 3, 2026

CI failing cuz there seems to be an on-going github outage:
image

https://www.githubstatus.com/

Will retry in a bit

@shvbsle
Copy link
Copy Markdown
Contributor Author

shvbsle commented Mar 4, 2026

/ci
+workflow:k8s_versions 1.34

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

@shvbsle roger that! I've dispatched a workflow. 👍

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

@shvbsle the workflow that you requested has completed.

K8s Version Arch Instance Type Result Details
1.34 amd64 t3.medium failure ❌ logs

⚠️ 1/1 version(s) failed

@shvbsle
Copy link
Copy Markdown
Contributor Author

shvbsle commented Mar 4, 2026

/ci
+workflow:k8s_versions 1.34

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

@shvbsle roger that! I've dispatched a workflow. 👍

@shvbsle shvbsle changed the title ci: no-op to test ci for node-destination ci: reduce flakiness and optimize resources Mar 4, 2026
@shvbsle shvbsle marked this pull request as ready for review March 4, 2026 02:41
@shvbsle shvbsle requested a review from prasad0896 March 4, 2026 02:41
Copy link
Copy Markdown

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

@shvbsle the workflow that you requested has completed.

K8s Version Arch Instance Type Result Details
1.34 amd64 t3.medium success ✅ logs

🎉 1/1 version(s) passed

@shvbsle shvbsle merged commit 631078f into aws:main Mar 4, 2026
2 checks passed
@shvbsle shvbsle deleted the ci-sanity branch March 4, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants