Skip to content

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Jul 2, 2025

Release Summary:

Resolved issues:

related to #5387.

Description of changes:

As described in the ticket, we should update our bindgen version to the most up to date version that supports MSRV 1.66.0. This PR does that.

Call-outs:

We should probably investigate why the Dependabot won't update the version for bindgen.

Testing:

I ran .generate.sh locally and the CI will test it too.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jul 2, 2025
@boquan-fang boquan-fang changed the title chore: update bindgen version to v0.72.0 chore: update bindgen version to v0.69.0 Jul 2, 2025
@boquan-fang boquan-fang marked this pull request as ready for review July 2, 2025 23:40
@boquan-fang boquan-fang requested review from jmayclin and jouho July 2, 2025 23:41
@@ -8,7 +8,7 @@ license = "Apache-2.0"
publish = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to the most up to date version that supports MSRV 1.66.0

Where is the 1.66 coming from?

I think our current MSRV is 1.63. I think we can now bump that, but we'd probably want to do that in a separate PR before merging this in?

Copy link

github-actions bot commented Sep 1, 2025

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants