Fix HKDF on big-endian #5478
Merged
Fix HKDF on big-endian #5478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Aug 25, 2025
lrstewart
approved these changes
Aug 25, 2025
goatgoose
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
resolves #4097
Description of changes:
Using the "first" byte of a uint32_t is endian dependent. Casting curr_round to a single byte type fist makes sure endianes doesn't have any affect.
Call-outs:
I am not entirely sure if there should may be a
& 0xffbefore the cast.Testing:
This has been tested on alpine linux s390x and ppc by running the unit tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.