Skip to content

add missing test dependencies for setup.py #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2020
Merged

add missing test dependencies for setup.py #40

merged 1 commit into from
Jan 30, 2020

Conversation

l2yao
Copy link
Contributor

@l2yao l2yao commented Jan 30, 2020

Issue #, if available:
we have docker dependency in tox.ini, but missing it in setup.py.

Description of changes:
added missing dependency.

Testing done:
Github Action workflow run successfully

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@l2yao l2yao requested a review from a team as a code owner January 30, 2020 21:05
@l2yao l2yao merged commit 11d5fa7 into aws:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants