Skip to content

fix: pin astroid to 2.4.2 #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2021
Merged

fix: pin astroid to 2.4.2 #2147

merged 1 commit into from
Feb 15, 2021

Conversation

metrizable
Copy link
Contributor

@metrizable metrizable commented Feb 15, 2021

Issue #, if available:

Description of changes:

a recent update to a transitive dep rolled in that caused breakages: https://pypi.org/project/astroid/#history

changes include:

  • pin astroid to 2.4.2 for the time being

Testing done:

❯ tox -e pylint
...
pylint installdeps: pylint, astroid==2.4.2
pylint installed: astroid==2.4.2,isort==5.7.0,lazy-object-proxy==1.4.3,mccabe==0.6.1,pylint==2.6.0,six==1.15.0,toml==0.10.2,wrapt==1.12.1
pylint run-test-pre: PYTHONHASHSEED='231695462'
pylint run-test: commands[0] | python -m pylint --rcfile=.pylintrc -j 0 src/sagemaker

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

______________________________________________ summary ______________________________________________
  pylint: commands succeeded
  congratulations :)
tox -e pylint  84.45s user 1.92s system 309% cpu 27.884 total

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@metrizable metrizable marked this pull request as ready for review February 15, 2021 22:49
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 20c342f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 20c342f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 20c342f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 20c342f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ajaykarpur ajaykarpur merged commit 0c305db into aws:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants