documentation: add TF 2.4.1 support to sm distributed data parallel docs and other updates #2179

TEChopra1000 · 2021-02-26T19:47:38Z

Description of changes:

Adding TF 2.4 support notes into SM distribute model parallel docs

Testing done:
tox -e black-check,flake8,pylint,docstyle,sphinx,doc8 --parallel all

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…arallel docs

… model parallel docs" This reverts commit 8377b86.

sagemaker-bot · 2021-02-26T19:48:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 028560e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-26T19:48:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 028560e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-26T19:49:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 028560e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-26T19:49:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 028560e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-26T19:57:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 028560e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

anirudh2290 · 2021-02-26T22:10:23Z

doc/api/training/smd_model_parallel_release_notes/smd_model_parallel_change_log.md

@@ -17,6 +17,10 @@

 - Adds support for `_register_comm_hook` (PyTorch 1.7 only) which will register the callable as a communication hook for DDP. NOTE: Like in DDP, this is an experimental API and subject to change.

+### Tensorflow
+
+- Adds support for Tensorflow 2.4


i think this should say 2.4.1 ?

I've added 2.4.1

sagemaker-bot · 2021-02-26T23:42:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b14ae5e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-26T23:43:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b14ae5e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-26T23:43:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b14ae5e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-26T23:44:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b14ae5e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-26T23:51:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b14ae5e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:05:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3613905
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:06:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3613905
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:06:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3613905
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:07:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3613905
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:09:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6e36366
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:09:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6e36366
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:10:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6e36366
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:10:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6e36366
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:14:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3613905
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:17:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6e36366
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

anirudh2290 · 2021-02-27T00:38:31Z

doc/api/training/smp_versions/v1.1.0/smd_model_parallel_tensorflow.rst

@@ -81,7 +81,7 @@ TensorFlow API
      [...]
      x = tf.constant(1.2)                     # placed in partition 0
      with smp.partition(1):
-          y = tf.add(x, tf.constant(2.3))      # placed in partition 1
+          y = tf.add(x, tf.constant(2.3.1))      # placed in partition 1


I don't think we want to change it here.

I removed this update.

sagemaker-bot · 2021-02-27T00:48:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1216b23
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:48:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1216b23
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

anirudh2290 · 2021-02-27T00:48:44Z

Thank you for the fixes @TEChopra1000 !

sagemaker-bot · 2021-02-27T00:49:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1216b23
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:50:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1216b23
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:57:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1216b23
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T00:57:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1726aff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T01:18:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1726aff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T01:25:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1726aff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-27T01:29:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1726aff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Talia Chopra added 3 commits February 11, 2021 14:55

documentation: removing mention of TF 2.4 from SM distributed model p…

8377b86

…arallel docs

Merge remote-tracking branch 'upstream/master'

3f498f4

Revert "documentation: removing mention of TF 2.4 from SM distributed…

028560e

… model parallel docs" This reverts commit 8377b86.

anirudh2290 reviewed Feb 26, 2021

View reviewed changes

Merge branch 'master' into master

b14ae5e

documentation: fixing version numbers for sm distributed mp

3613905

documentation: additional typo fixes for version number smd

6e36366

anirudh2290 previously approved these changes Feb 27, 2021

View reviewed changes

documentation: typo fix sm distributed model parallel api docs

1726aff

TEChopra1000 dismissed anirudh2290’s stale review via 1726aff February 27, 2021 00:47

Merge branch 'master' into master

1216b23

anirudh2290 approved these changes Feb 27, 2021

View reviewed changes

ChoiByungWook changed the title ~~Documentation: adding TF 2.4 support to sm distributed data parallel docs~~ documentation: add TF 2.4 support to sm distributed data parallel docs Feb 27, 2021

ChoiByungWook approved these changes Feb 27, 2021

View reviewed changes

ChoiByungWook changed the title ~~documentation: add TF 2.4 support to sm distributed data parallel docs~~ documentation: add TF 2.4.1 support to sm distributed data parallel docs and other updates Feb 27, 2021

ChoiByungWook merged commit c551256 into aws:master Feb 27, 2021

documentation: add TF 2.4.1 support to sm distributed data parallel docs and other updates #2179

documentation: add TF 2.4.1 support to sm distributed data parallel docs and other updates #2179

Uh oh!

Conversation

TEChopra1000 commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

anirudh2290 Feb 26, 2021

Choose a reason for hiding this comment

Uh oh!

TEChopra1000 Feb 27, 2021

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 26, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2021

AWS CodeBuild CI Report

Uh oh!

anirudh2290 Feb 27, 2021

Choose a reason for hiding this comment

Uh oh!

TEChopra1000 Feb 27, 2021

TEChopra1000 commented Feb 26, 2021 •

edited

Loading