Skip to content

fix: clarify model monitor one time schedule bug #5169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sagemaker/model_monitor/clarify_model_monitoring.py
Original file line number Diff line number Diff line change
Expand Up @@ -1103,6 +1103,8 @@ def create_monitoring_schedule(
monitor_schedule_name=monitor_schedule_name,
job_definition_name=new_job_definition_name,
schedule_cron_expression=schedule_cron_expression,
data_analysis_start_time=data_analysis_start_time,
data_analysis_end_time=data_analysis_end_time,
)
self.job_definition_name = new_job_definition_name
self.monitoring_schedule_name = monitor_schedule_name
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/sagemaker/monitor/test_clarify_model_monitor.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
subnets=SUBNETS,
)
CRON_HOURLY = CronExpressionGenerator.hourly()
CRON_NOW = CronExpressionGenerator.now()
ENDPOINT_NAME = "endpoint"
GROUND_TRUTH_S3_URI = "s3://bucket/monitoring_captured/actuals"
ANALYSIS_CONFIG_S3_URI = "s3://bucket/analysis_config.json"
Expand Down Expand Up @@ -1305,6 +1306,66 @@ def test_model_explainability_monitor(model_explainability_monitor, sagemaker_se
)


def test_model_explainability_create_one_time_schedule(
model_explainability_monitor, sagemaker_session
):
endpoint_input = EndpointInput(
endpoint_name=ENDPOINT_NAME,
destination=ENDPOINT_INPUT_LOCAL_PATH,
features_attribute=FEATURES_ATTRIBUTE,
inference_attribute=str(INFERENCE_ATTRIBUTE),
)

# Create one-time schedule
with patch(
"sagemaker.s3.S3Uploader.upload_string_as_file_body", return_value=ANALYSIS_CONFIG_S3_URI
) as _:
model_explainability_monitor.create_monitoring_schedule(
endpoint_input=endpoint_input,
analysis_config=ANALYSIS_CONFIG_S3_URI,
output_s3_uri=OUTPUT_S3_URI,
monitor_schedule_name=SCHEDULE_NAME,
schedule_cron_expression=CRON_NOW,
data_analysis_start_time=START_TIME_OFFSET,
data_analysis_end_time=END_TIME_OFFSET,
)

# Validate job definition creation
sagemaker_session.sagemaker_client.create_model_explainability_job_definition.assert_called_once()
job_definition_args = (
sagemaker_session.sagemaker_client.create_model_explainability_job_definition.call_args[1]
)
assert (
job_definition_args["JobDefinitionName"] == model_explainability_monitor.job_definition_name
)
assert job_definition_args == {
"JobDefinitionName": model_explainability_monitor.job_definition_name,
**EXPLAINABILITY_JOB_DEFINITION,
"Tags": TAGS,
}

# Validate monitoring schedule creation
sagemaker_session.sagemaker_client.create_monitoring_schedule.assert_called_once()
schedule_args = sagemaker_session.sagemaker_client.create_monitoring_schedule.call_args[1]
assert schedule_args == {
"MonitoringScheduleName": SCHEDULE_NAME,
"MonitoringScheduleConfig": {
"MonitoringJobDefinitionName": model_explainability_monitor.job_definition_name,
"MonitoringType": "ModelExplainability",
"ScheduleConfig": {
"ScheduleExpression": CRON_NOW,
"DataAnalysisStartTime": START_TIME_OFFSET,
"DataAnalysisEndTime": END_TIME_OFFSET,
},
},
"Tags": TAGS,
}

# Check if the monitoring schedule is stored in the monitor object
assert model_explainability_monitor.monitoring_schedule_name == SCHEDULE_NAME
assert model_explainability_monitor.job_definition_name is not None


def test_model_explainability_batch_transform_monitor(
model_explainability_monitor, sagemaker_session
):
Expand Down