ApplicationContextException: Unable to start ServletWebServerApplicationContext

[boroda4436]

• Framework version: aws-cli/2.0.0dev4 Python/3.7.4 Darwin/19.2.0 botocore/2.0.0dev3
• Implementations: Spring Boot

Scenario

Run the spring-boot2 app locally

Expected behavior

the app starts without exceptions

Actual behavior

error happens:

Steps to reproduce

1. Download the repo
2. cd samples/springboot2/pet-store
3. Run com.amazonaws.serverless.sample.springboot2.Application from your IDE as a simple spring-boot app.

Full log output

2020-02-26 15:57:01.303 INFO 59255 --- [ main] c.a.s.sample.springboot2.Application : Starting Application on Bogdans-MBP.mate.academy with PID 59255 (/Users/bchupika/IdeaProjects/Study/aws-serverless-java-container/samples/springboot2/pet-store/target/classes started by bchupika in /Users/bchupika/IdeaProjects/Study/aws-serverless-java-container)
2020-02-26 15:57:01.312 INFO 59255 --- [ main] c.a.s.sample.springboot2.Application : No active profile set, falling back to default profiles: default
2020-02-26 15:57:02.082 ERROR 59255 --- [ main] o.s.boot.SpringApplication : Application run failed

org.springframework.context.ApplicationContextException: Unable to start web server; nested exception is org.springframework.context.ApplicationContextException: Unable to start ServletWebServerApplicationContext due to missing ServletWebServerFactory bean.
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:156)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:543)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:141)
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:744)
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:391)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:312)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1215)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1204)
at com.amazonaws.serverless.sample.springboot2.Application.main(Application.java:47)
Caused by: org.springframework.context.ApplicationContextException: Unable to start ServletWebServerApplicationContext due to missing ServletWebServerFactory bean.
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.getWebServerFactory(ServletWebServerApplicationContext.java:203)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.createWebServer(ServletWebServerApplicationContext.java:179)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:153)
... 8 common frames omitted

Process finished with exit code 1

[sapessi]

This is probably cause by the fact that we explicitly exclude the embedded Tomcat that implements ServletWebServerFactory.

To solve this, we could remove the exclusion from the dependency and simply shade Tomcat out when producing a build for AWS Lambda. Would that help?

[sapessi]

@boroda4436 I found the root cause and committed a fix in the v1.5 branch. We'll have this out with the next release shortly. I have also added a new feature to the builder that allows you to specify whether you want to start a WebApplicationType.SERVLET: Test sample

[jchambers]

Hi! I'm afraid I'm still having this problem even after the 1.5 release. I created a new project with:

mvn archetype:generate -DgroupId=my.service -DartifactId=my-service -Dversion=1.0-SNAPSHOT \
       -DarchetypeGroupId=com.amazonaws.serverless.archetypes \
       -DarchetypeArtifactId=aws-serverless-springboot2-archetype \
       -DarchetypeVersion=1.5

Attempting to start the included Application either through an IDE or via Maven produces the same problem.

[sapessi]

The archetype by default excludes the embedded Tomcat since it is not useful in Lambda - this is why Spring can't find an implementation of ServletWebServerFactory. You can just uncomment the exclusion from the pom file:

<dependency>
   <groupId>org.springframework.boot</groupId>
   <artifactId>spring-boot-starter-web</artifactId>
   <!--exclusions>
       <exclusion>
           <groupId>org.springframework.boot</groupId>
           <artifactId>spring-boot-starter-tomcat</artifactId>
        </exclusion>
    </exclusions-->
</dependency>

Fair point though. I'll create a separate issue to track moving this into a profile for the next release

[jchambers]

It's true that removing that exclusion eliminates the exception, but the Spring Boot application still doesn't start up all the way; instead, it appears to hang shortly after displaying the Spring Boot banner. I think there may be something else at play.

[jchambers]

I was mistaken, and I apologize for the false alarm; I missed that the default logging level for the project is WARN, and so all of the usual startup messages (at INFO or lower) weren't displayed. Everything is working as expected.

[sapessi]

No worries. For the next release, we'll make sure to include the correct profiles in the archetypes.

[bbehling]

I'm using version 1.5 and still need to comment out the exclusions. Was 1.5 supposed to include a fix where we didn't have to comment that out?

[SaptarshiMisra]

I'm using version 1.5. Getting this error. Could you please share some thoughts

java.lang.NoClassDefFoundError: org/springframework/boot/WebApplicationType
	at com.amazonaws.serverless.proxy.spring.SpringBootProxyHandlerBuilder.<init>(SpringBootProxyHandlerBuilder.java:32)
	at com.amazonaws.serverless.proxy.spring.SpringBootLambdaContainerHandler.getAwsProxyHandler(SpringBootLambdaContainerHandler.java:88)
	at com.inboxy.api.StreamLambdaHandler.<clinit>(StreamLambdaHandler.java:20)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
Caused by: java.lang.ClassNotFoundException: org.springframework.boot.WebApplicationType
	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	... 5 more

this is how I am including the spring-boot-starter-web

<dependency>
      <groupId>org.springframework.boot</groupId>
      <artifactId>spring-boot-starter-web</artifactId>
    </dependency>

[SamnnyWong]

Hi, I am still having this issue, could anyone take a look?
Log:

2021-11-24 22:28:55.891  INFO 17394 --- [           main] c.a.s.sample.springboot2.Application     : Starting Application using Java 1.8.0_191 on Sams-MBP with PID 17394 (/Users/sam/Documents/spring/limit/pet-store/build/classes/java/main started by sam in /Users/sam/Documents/spring/limit/pet-store)
2021-11-24 22:28:55.892  INFO 17394 --- [           main] c.a.s.sample.springboot2.Application     : No active profile set, falling back to default profiles: default
2021-11-24 22:28:56.589 ERROR 17394 --- [           main] o.s.boot.SpringApplication               : Application run failed

org.springframework.context.ApplicationContextException: Unable to start web server; nested exception is org.springframework.context.ApplicationContextException: Unable to start ServletWebServerApplicationContext due to missing ServletWebServerFactory bean.
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:163)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:577)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:145)
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:754)
	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:434)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:338)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1343)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1332)
	at com.amazonaws.serverless.sample.springboot2.Application.main(Application.java:47)
Caused by: org.springframework.context.ApplicationContextException: Unable to start ServletWebServerApplicationContext due to missing ServletWebServerFactory bean.
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.getWebServerFactory(ServletWebServerApplicationContext.java:210)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.createWebServer(ServletWebServerApplicationContext.java:180)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:160)
	... 8 common frames omitted

I change my dependency package like this
pom.xml:

 <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-tomcat</artifactId>
            <scope>compile</scope>
        </dependency>

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-web</artifactId>
<!--            <exclusions>-->
<!--                <exclusion>-->
<!--                    <groupId>org.springframework.boot</groupId>-->
<!--                    <artifactId>spring-boot-starter-tomcat</artifactId>-->
<!--                </exclusion>-->
<!--            </exclusions>-->
        </dependency>

after many tries, I still couldn't make it work.
We want to run and test it locally before deploying it to lambda.
Any helps will be appreciated.

[deki]

Hmm we have working sample projects in https://github.com/awslabs/aws-serverless-java-container/tree/master/samples that you can use to compare. Or you'll share your non-working sample and we'll have a look?