Skip to content

Provide first module to run Struts2 based applications as AWS Lambda … #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Provide first module to run Struts2 based applications as AWS Lambda … #159

wants to merge 12 commits into from

Conversation

jogep
Copy link
Contributor

@jogep jogep commented Jun 20, 2018

Provide first module to run Struts2 based applications as AWS Lambda functions

#149

@jogep jogep mentioned this pull request Jun 20, 2018
Closed
sapessi
sapessi suggested changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@sapessi sapessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and minor nit-picky issues. I'll hold this here until the 1.1.1 is out and I'm ready to merge with 1.2-SNAPSHOT.

aws-serverless-java-container-struts2/pom.xml Outdated
<groupId>org.apache.struts</groupId>
<artifactId>struts2-core</artifactId>
<version>${struts2.version}</version>
<optional>true</optional>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this optional because you expect developers to pick their own version of Struts2? If we want to enable this, we should make sure that this can support most versions of struts 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right struts2-core should be required when this lib is used. I changed this.

@sapessi
Copy link
Contributor

sapessi commented Jun 20, 2018

No rush on docs + archetype, 1.2 is likely going out in a few weeks. It's not necessary for publication, but when you get a chance it would be good to include a pet store sample in this repo like we have for the other frameworks.

@sapessi sapessi mentioned this pull request Aug 17, 2018
Closed
@jogep
Copy link
Contributor Author

jogep commented Aug 18, 2018

Hi @sapessi,

For a quick start I added a initial WIKI page for instructions and references in the README.
I will add more samples and archetypes soon.

https://github.com/awslabs/aws-serverless-java-container/wiki/Quick-start-Struts

@jogep
Copy link
Contributor Author

jogep commented Sep 8, 2018

Hi @sapessi,

I created a pet store example similar to the other frameworks.

I hope this is already a goof starting point for struts2 based lambdas.

Best Regards

Johannes

@sapessi
Copy link
Contributor

sapessi commented Oct 19, 2018

I've merged this into the core branch where I'm working on the next release. Closing the pull request.

@sapessi sapessi closed this Oct 19, 2018
@sapessi sapessi added this to the Release 1.2 milestone Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapessi sapessi sapessi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jogep @sapessi