Skip to content

Speeding up the build: libwebsockets#2211

Merged
sirknightj merged 1 commit into
developfrom
libwebsockets-skip-samples
Feb 4, 2026
Merged

Speeding up the build: libwebsockets#2211
sirknightj merged 1 commit into
developfrom
libwebsockets-skip-samples

Conversation

@sirknightj

Copy link
Copy Markdown
Contributor

Issue #, if available:

  • N/A

What was changed?

  • Don't build the sample applications

Why was it changed?

  • Saw lines in the build log (see below) that indicated that samples were being built

How was it changed?

  • Turned off the samples

What testing was done for the changes?

  • Checked the new build log which doesn't the above log lines anymore
Before After
image image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj sirknightj merged commit 3b44add into develop Feb 4, 2026
111 of 113 checks passed
@sirknightj sirknightj deleted the libwebsockets-skip-samples branch February 4, 2026 20:46
@sirknightj

Copy link
Copy Markdown
Contributor Author

According to CI, the build phase went from 4:40~4:50 down to about 4:25-4:40

sirknightj added a commit that referenced this pull request Feb 17, 2026
* Scoped down github action permission to the minimum requirement (#2195)

Co-authored-by: Yuqi Huang <yuuqih@amazon.com>

* Update libkvsCommonLws to version 1.6.1 (#2197)

* Support IPv6 TURN Allocations (#2194)

* Add back ipv6 turn allocation changes

* Swap order of relay candidate inits so IPv6 comes first

* Envvar control of TURN IP family to use (#2198)

* Use the new isEnvVarEnabled func from PIC

* Add envvar control of relay candidate IP family types

* Add new envvars description to the ReadMe

* clang format

* Update ReadMe

* Update ReadMe

* Signaling Cache Improvements (#2199)

* Start on signaling cache improvements

* Switch to using the new isEnvVarEnabled func

* Update signaling unit tests to reflect changes

* Update cache file name version, update ReadMe

* clang format

* Add validation for empty new entries and consistency across caches

* Fix typo in test

* Remove extra region instances (#2201)

* Improve error handling in the master sample pipeline (#2200)

* Improve error handling in the master sample pipeline

* Address comments

* control plane uri env override (#2202)

* env to set the transport setting (#2203)

* Fix turn server parsing, getaddrinfo fallback value to get used (#2205)

* Add a forceTurn check to the CI (#2204)

* Add a forceTurn check to the CI

* Print the exit code in case of error

* Cache ci (#2206)

* ci: Add cache functionality test with dual-stack endpoint toggling

Add comprehensive CI workflow to verify cache behavior when toggling
KVS_DUALSTACK_ENDPOINTS environment variable. Tests run samples in
4-step sequence (set/unset/set/unset) to ensure proper caching of
endpoint configurations between dual-stack and legacy modes.

- Tests both kvsWebrtcClientMaster and kvsWebrtcClientViewer samples
- Uses unique channel names per test run to avoid conflicts

* fix: improve process management in cache dualstack test workflow

Fix viewer process issues by simplifying PID tracking approach to match
proven pattern from samples.yaml workflow.

* ci: update endpoint verification to use setRequestHeader log patterns

Change endpoint detection from generic URL patterns to specific
setRequestHeader() log analysis for accurate dual-stack vs legacy
endpoint verification. Completes comprehensive cache functionality
testing with proper endpoint validation.

* remove unneccesary checks in the yml file

* change endpoint we're using as we switch between dual-stack mode

* ci: improve credential check and use consistent channel naming for cache tests

- Split credential check into conditional job pattern.
- Use same channel name across all tests to properly verify cache updating behavior.

---------

Co-authored-by: Yuqi Huang <yuuqih@amazon.com>

* Log when the codec type is not supported (#2189)

* Log when the codec type is not supported

* clang-format

* Re-trigger CI due to GitHub outage

* Add README table for samples (#2207)

* Add README table

* Re-trigger CI due to GitHub outage

* Create storage-samples.yml (#2171)

* Create storage-samples.yml

storage sample prep

* Add e2e media validation infra (currently disabled), and provisioning infra

---------

Co-authored-by: sirknightj <jggunawa@amazon.com>

* Speed up AWS SDK CPP build (#2209)

* Zero-initialize Signaling message struct (#2208)

* Disable building minimal examples (#2211)

* Add CI to generate profile stats for the sample (#2212)

* Add CI to generate profile stats for the sample

* Add additional logging in the CI

* Fix file path for the logging files

* clang-format

* Increase min count to 4

* Check in range log

* connectionListener: Yield till timeout if no fds set (#2213)

- Till the time session is active, we keep polling on active sockets
 - For this time period, if there is no data on any sockets, we may keep spinning
 - Solution: Sleep for timeout milliseconds in no-data case

* Bump the project version to 1.16.0 (#2215)

---------

Co-authored-by: Yuqi Huang <125420341+YPandas@users.noreply.github.com>
Co-authored-by: Yuqi Huang <yuuqih@amazon.com>
Co-authored-by: Stefan Kieszkowski <85728496+stefankiesz@users.noreply.github.com>
Co-authored-by: Siva Somasundaram <34496097+unicornss@users.noreply.github.com>
Co-authored-by: Vikram Dattu <vikram.dattu@espressif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build dependency Related to a dependency v1.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants