Skip to content

Fix compile warning in the test#2220

Merged
sirknightj merged 1 commit into
developfrom
fix-test-warning
Feb 19, 2026
Merged

Fix compile warning in the test#2220
sirknightj merged 1 commit into
developfrom
fix-test-warning

Conversation

@sirknightj

Copy link
Copy Markdown
Contributor

Issue #, if available:

  • N/A

What was changed?

  • Fix a compile warning in the test
/__w/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/tst/CustomEndpointTest.cpp: In member function 'virtual void com::amazonaws::kinesis::video::webrtcclient::CustomEndpointTest_customControlPlaneEndpointBasicCase_Test::TestBody()':
/__w/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/tst/CustomEndpointTest.cpp:28:32: warning: ISO C++ forbids converting a string constant to 'PCHAR' {aka 'char*'} [-Wwrite-strings]
   28 |     channelInfo.pChannelName = "TestChannelName";
      |                                ^~~~~~~~~~~~~~~~~
/__w/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/tst/CustomEndpointTest.cpp: In member function 'virtual void com::amazonaws::kinesis::video::webrtcclient::CustomEndpointTest_customControlPlaneEndpointEdgeCases_Test::TestBody()':
/__w/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/tst/CustomEndpointTest.cpp:60:32: warning: ISO C++ forbids converting a string constant to 'PCHAR' {aka 'char*'} [-Wwrite-strings]
   60 |     channelInfo.pChannelName = "TestChannelName";
      |                                ^~~~~~~~~~~~~~~~~
/__w/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/tst/CustomEndpointTest.cpp: In member function 'virtual void com::amazonaws::kinesis::video::webrtcclient::CustomEndpointTest_customControlPlaneEndpointTooLong_Test::TestBody()':
/__w/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/tst/CustomEndpointTest.cpp:126:32: warning: ISO C++ forbids converting a string constant to 'PCHAR' {aka 'char*'} [-Wwrite-strings]
  126 |     channelInfo.pChannelName = "TestChannelName";
      |                                ^~~~~~~~~~~~~~~~~

Why was it changed?

  • Less compile warnings

How was it changed?

  • Cast to PCHAR

What testing was done for the changes?

  • Built locally and no more warning

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread tst/CustomEndpointTest.cpp
@sirknightj sirknightj merged commit ec04914 into develop Feb 19, 2026
80 checks passed
sirknightj added a commit that referenced this pull request Feb 26, 2026
* Fix port printing for some logs (#2217)

* Fix port printing

* Address comments

* Clarify mediaType options in README (#2221)

* Fix compile warning (#2220)

* Add send video-only mode (#2222)

* Initial implementation

* Upgrade senderreport logs to debug

* Add env for dont send audio

* Add unit tests for writeTransceiverDirection and intersectTransceiverDirection

* Add SDP construction tests for intersection with local transceivers

* clang-format

* Validate input for transceiver direction and default to sendrecv if not valid (#2223)

* Use parameterized test for the transceiver direction matrix, also handle invalid args (#2225)

* Print the signaling message when it failed to parse (#2228)

* Print the message that it failed to parse

* Added length check just in case

* Expand combinations for dynamic transceiver directions (#2226)

* Expand to full combinations for dynamic directions

* Add comment

* Split the samples into p2p and webrtc ingest samples (#2224)

* Break apart master static frames sample into p2p and ingestion samples

* Split the Gst sample into multiple

* Fix build issue

* Clang-format and remove extra code changes

* Adjust README for new samples

* Address comments

* Bump the version to 1.17.0 (#2230)

* Add readonly permission for the stack size check job (#2233)

* WebRTC storage readme (#2232)

---------

Co-authored-by: Umut Tezduyar Lindskog <umut@tezduyar.com>
@sirknightj sirknightj deleted the fix-test-warning branch May 29, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants