fix: respect severity_threshold in SARIF file actionable count#329
Merged
Conversation
The SARIF file-based actionable findings count in run_ash_scan was counting all non-suppressed findings regardless of the configured severity_threshold. This caused ASH to exit with code 2 (actionable findings detected) even when all findings were below the threshold (e.g., LOW findings with MEDIUM threshold). The fix applies the severity_threshold when counting from the SARIF file by: - Resolving the effective threshold from ash_config.global_settings - Checking issue_severity properties first (explicit scanner severity) - Falling back to SARIF level mapping (error->critical, warning->medium, note->low) - Only counting findings at or above the configured threshold Includes 26 regression tests covering threshold filtering, SARIF file count behavior, explicit issue_severity handling, and end-to-end scenarios.
Contributor
ASH Security Scan Report
Scan Metadata
SummaryScanner ResultsThe table below shows findings by scanner, with status based on severity thresholds and dependencies:
Report generated by Automated Security Helper (ASH) at 2026-05-11T22:51:58+00:00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The SARIF file-based actionable findings count in run_ash_scan was counting all non-suppressed findings regardless of the configured severity_threshold. This caused ASH to exit with code 2 (actionable findings detected) even when all findings were below the threshold (e.g., LOW findings with MEDIUM threshold).
The fix applies the severity_threshold when counting from the SARIF file by:
Includes 26 regression tests covering threshold filtering, SARIF file count behavior, explicit issue_severity handling, and end-to-end scenarios.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.