generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 333
added unit tests for athena-vertica. #2783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
58f4002
added unit tests for athena-vertica.
ritiktrianz 0ac0893
Merge branch 'master' into add-unit-tests-vertica
ritiktrianz 41951eb
Merge branch 'master' into add-unit-tests-vertica
fal-bharadwaj 0ca80f1
Merge branch 'master' into add-unit-tests-vertica
ritiktrianz e1b2d0a
Merge branch 'master' into add-unit-tests-vertica
ritiktrianz 65e71b3
review comment changes.
ritiktrianz fe902d6
Merge remote-tracking branch 'origin/add-unit-tests-vertica' into add…
ritiktrianz 3473603
Merge branch 'master' into add-unit-tests-vertica
fal-bharadwaj b723aea
Merge branch 'master' into add-unit-tests-vertica
fal-bharadwaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
56 changes: 56 additions & 0 deletions
56
...c/test/java/com/amazonaws/athena/connectors/vertica/VerticaEnvironmentPropertiesTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /*- | ||
| * #%L | ||
| * athena-vertica | ||
| * %% | ||
| * Copyright (C) 2019 - 2025 Amazon Web Services | ||
| * %% | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * #L% | ||
| */ | ||
| package com.amazonaws.athena.connectors.vertica; | ||
|
|
||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import static com.amazonaws.athena.connector.lambda.connection.EnvironmentConstants.DATABASE; | ||
| import static com.amazonaws.athena.connector.lambda.connection.EnvironmentConstants.DEFAULT; | ||
| import static com.amazonaws.athena.connector.lambda.connection.EnvironmentConstants.HOST; | ||
| import static com.amazonaws.athena.connector.lambda.connection.EnvironmentConstants.PORT; | ||
| import static com.amazonaws.athena.connector.lambda.connection.EnvironmentConstants.SECRET_NAME; | ||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| public class VerticaEnvironmentPropertiesTest { | ||
| private Map<String, String> connectionProperties; | ||
| private VerticaEnvironmentProperties verticaEnvironmentProperties; | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| connectionProperties = new HashMap<>(); | ||
| connectionProperties.put(HOST, "vertica-cluster-endpoint"); | ||
| connectionProperties.put(DATABASE, "verticadb"); | ||
| connectionProperties.put(SECRET_NAME, "vertica-secret"); | ||
| connectionProperties.put(PORT, "1234"); | ||
| verticaEnvironmentProperties = new VerticaEnvironmentProperties(); | ||
| } | ||
|
|
||
| @Test | ||
| public void verticaConnectionPropertiesTest() { | ||
| Map<String, String> verticaConnectionProperties = verticaEnvironmentProperties.connectionPropertiesToEnvironment(connectionProperties); | ||
|
|
||
| String expectedConnectionString = "vertica://jdbc:vertica://vertica-cluster-endpoint:1234/verticadb?${vertica-secret}"; | ||
| assertEquals(expectedConnectionString, verticaConnectionProperties.get(DEFAULT)); | ||
| } | ||
| } | ||
297 changes: 241 additions & 56 deletions
297
...ica/src/test/java/com/amazonaws/athena/connectors/vertica/VerticaMetadataHandlerTest.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add negative test cases here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You, added test cases for negative scenarios.