Skip to content

Conversation

@jobrandw
Copy link
Contributor

@jobrandw jobrandw commented Apr 5, 2021

Description of changes:
Config files (pom and yaml) were updated for the new release version, 2021.14.1.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@burhan94
Copy link
Collaborator

burhan94 commented Apr 5, 2021

Can you also remove any mentions of the preview pool? (AmazonAthenaPreviewFunctionality)

1. Navigate to [Servless Application Repository](https://console.aws.amazon.com/serverlessrepo/home#/available-applications) and search for "athena-federation". Be sure to check the box to show entries that require custom IAM roles.
1. Look for entries published by the "Amazon Athena Federation" author.
1. Deploy the application
1. Go to the [Athena Console in us-east-1 (N. Virginia)](https://console.aws.amazon.com/athena/home) and create a workgroup called "AmazonAthenaPreviewFunctionality", any queries run from that workgroup will be able to use Preview features described in this repository. If you are running a federated query in US-East-1, Us-East-2, or Us-West-2, you can use any workgroup as long as you have set your engine setting to V2. See Engine Versions here:https://docs.aws.amazon.com/athena/latest/ug/engine-versions.html.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revise this please? We should document that FQ is only available on V2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the entire line since we still have

Athena Federated Queries are now enabled as GA in us-east-1, us-east-2, us-west-2, eu-west-1, ap-northeast-1, ap-south-1, us-west-1, ap-southeast-1, ap-southeast-2, eu-west-2, ap-northeast-2, eu-west-3, ca-central-1, sa-east-1, and eu-central-1. To use this feature, upgrade your engine version to Athena V2 in your workgroup settings. Check documentation here for more details: https://docs.aws.amazon.com/athena/latest/ug/engine-versions.html.

earlier in the readme

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine here to reiterate, since its a walkthrough and we shouldn't have to expect users to jump back and forth tbh.

@jobrandw jobrandw requested a review from burhan94 April 5, 2021 17:25
@jobrandw jobrandw merged commit 14bee28 into master Apr 5, 2021
@jobrandw jobrandw deleted the release-2021.14.1 branch April 5, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants