Add support for WIN ARM64 #1092
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
- Coverage 83.23% 83.10% -0.13%
==========================================
Files 56 56
Lines 5808 5766 -42
==========================================
- Hits 4834 4792 -42
Misses 974 974 ☔ View full report in Codecov by Sentry. |
| @@ -71,6 +89,32 @@ typedef long aws_atomic_impl_int_t; | |||
| typedef long long aws_atomic_impl_int_t; | |||
| #endif | |||
|
|
|||
| #ifdef _M_ARM64 | |||
| /* Hardware Read Write barrier, prevents all memory operations to cross the barrier in both directions */ | |||
| # define AWS_RW_BARRIER() __dmb(_ARM64_BARRIER_SY) | |||
There was a problem hiding this comment.
These are new (seemingly) public symbols, which are only defined on MSVC... should we namespace them to make it clear they are internal?
There was a problem hiding this comment.
I am undefining them at the bottom of the file, so they should be OK in term of external symbol visibility
| * Volatile ops may or may not imply this barrier, depending on the /volatile: switch, but adding an extra | ||
| * barrier doesn't hurt. | ||
| */ | ||
| # define AWS_SW_BARRIER() _ReadWriteBarrier(); /* software barrier */ |
There was a problem hiding this comment.
not needed, but i thought it looks better
but i can remove it and replace it
@bdonlan, |
Add support for ARM64 on Windows
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.