Skip to content

Add LocalEnvironment using stdout #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions aws_embedded_metrics/environment/default_environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from aws_embedded_metrics.config import get_config
from aws_embedded_metrics.environment import Environment
from aws_embedded_metrics.logger.metrics_context import MetricsContext
from aws_embedded_metrics.sinks import Sink
from aws_embedded_metrics.sinks.agent_sink import AgentSink
from typing import Optional

Expand All @@ -22,7 +23,7 @@

class DefaultEnvironment(Environment):
def __init__(self) -> None:
self.sink: Optional[AgentSink] = None
self.sink: Optional[Sink] = None

async def probe(self) -> bool:
return True
Expand All @@ -39,7 +40,7 @@ def get_log_group_name(self) -> str:
def configure_context(self, context: MetricsContext) -> None:
pass

def get_sink(self) -> AgentSink:
def get_sink(self) -> Sink:
if self.sink is None:
self.sink = AgentSink(self.get_log_group_name(), Config.log_stream_name)
return self.sink
4 changes: 4 additions & 0 deletions aws_embedded_metrics/environment/environment_detector.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from aws_embedded_metrics.environment import Environment
from aws_embedded_metrics.environment.default_environment import DefaultEnvironment
from aws_embedded_metrics.environment.lambda_environment import LambdaEnvironment
from aws_embedded_metrics.environment.local_environment import LocalEnvironment
from aws_embedded_metrics.environment.ec2_environment import EC2Environment
from typing import Optional

Expand All @@ -24,6 +25,7 @@
lambda_environment = LambdaEnvironment()
ec2_environment = EC2Environment()
default_environment = DefaultEnvironment()
local_environment = LocalEnvironment()
environments = [lambda_environment, ec2_environment]
Config = config.get_config()

Expand All @@ -45,6 +47,8 @@ async def resolve_environment() -> Environment:
EnvironmentCache.environment = ec2_environment
elif lower_configured_enviroment == "default":
EnvironmentCache.environment = default_environment
elif lower_configured_enviroment == "local":
EnvironmentCache.environment = local_environment
else:
log.info("Failed to understand environment override: %s", Config.environment)
if EnvironmentCache.environment is not None:
Expand Down
4 changes: 2 additions & 2 deletions aws_embedded_metrics/environment/lambda_environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from aws_embedded_metrics.environment import Environment
from aws_embedded_metrics.logger.metrics_context import MetricsContext
from aws_embedded_metrics.sinks import Sink
from aws_embedded_metrics.sinks.lambda_sink import LambdaSink
from aws_embedded_metrics.sinks.stdout_sink import StdoutSink
import os


Expand All @@ -24,7 +24,7 @@ def get_env(key: str) -> str:
return ""


sink = LambdaSink()
sink = StdoutSink()


class LambdaEnvironment(Environment):
Expand Down
46 changes: 46 additions & 0 deletions aws_embedded_metrics/environment/local_environment.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# Copyright 2019 Amazon.com, Inc. or its affiliates.
# Licensed under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from aws_embedded_metrics.config import get_config
from aws_embedded_metrics.environment import Environment
from aws_embedded_metrics.logger.metrics_context import MetricsContext
from aws_embedded_metrics.sinks import Sink
from aws_embedded_metrics.sinks.stdout_sink import StdoutSink
from typing import Optional

Config = get_config()


class LocalEnvironment(Environment):
def __init__(self) -> None:
self.sink: Optional[Sink] = None

async def probe(self) -> bool:
return False

def get_name(self) -> str:
return Config.service_name or "Unknown"

def get_type(self) -> str:
return Config.service_type or "Unknown"

def get_log_group_name(self) -> str:
return Config.log_group_name or f"{self.get_name()}-metrics"

def configure_context(self, context: MetricsContext) -> None:
pass

def get_sink(self) -> Sink:
if self.sink is None:
self.sink = StdoutSink()
return self.sink
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,15 @@
from aws_embedded_metrics.serializers.log_serializer import LogSerializer


class LambdaSink(Sink):
class StdoutSink(Sink):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

def __init__(self, serializer: Serializer = LogSerializer()):
self.serializer = serializer

def accept(self, context: MetricsContext) -> None:
for serialized_content in self.serializer.serialize(context):
print(serialized_content)
if serialized_content:
print(serialized_content)

@staticmethod
def name() -> str:
return "LambdaSink"
return "StdoutSink"
4 changes: 2 additions & 2 deletions tests/environment/test_lambda_environment.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os
from aws_embedded_metrics.environment.lambda_environment import LambdaEnvironment
from aws_embedded_metrics.sinks.lambda_sink import LambdaSink
from aws_embedded_metrics.sinks.stdout_sink import StdoutSink
import pytest
from faker import Faker

Expand Down Expand Up @@ -65,4 +65,4 @@ def test_create_sink_creates_LambdaSink():
result = env.get_sink()

# assert
assert isinstance(result, LambdaSink)
assert isinstance(result, StdoutSink)
108 changes: 108 additions & 0 deletions tests/environment/test_local_environment.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
from aws_embedded_metrics import config
from aws_embedded_metrics.environment.local_environment import LocalEnvironment
from aws_embedded_metrics.sinks.stdout_sink import StdoutSink
import pytest
from faker import Faker

Config = config.get_config()
fake = Faker()


@pytest.mark.asyncio
async def test_probe_always_returns_false():
# arrange
env = LocalEnvironment()

# act
result = await env.probe()

# assert
assert result is False


def test_get_name_returns_unknown_if_not_specified():
# arrange
env = LocalEnvironment()
Config.service_name = None

# act
result = env.get_name()

# assert
assert result == "Unknown"


def test_get_type_returns_unknown_if_not_specified():
# arrange
env = LocalEnvironment()
Config.service_type = None

# act
result = env.get_type()

# assert
assert result == "Unknown"


def test_get_name_returns_name_if_configured():
# arrange
expected_name = fake.word()
env = LocalEnvironment()
Config.service_name = expected_name

# act
result = env.get_name()

# assert
assert result == expected_name


def test__get_type__returns_type_if_configured():
# arrange
expected_type = fake.word()
env = LocalEnvironment()
Config.service_type = expected_type

# act
result = env.get_type()

# assert
assert result == expected_type


def test__get_log_group_name__returns_log_group_if_configured():
# arrange
expected = fake.word()
env = LocalEnvironment()
Config.log_group_name = expected

# act
result = env.get_log_group_name()

# assert
assert result == expected


def test__get_log_group_name__returns_service_name_metrics_if_not_configured():
# arrange
expected = fake.word()
env = LocalEnvironment()
Config.service_name = expected
Config.log_group_name = None

# act
result = env.get_log_group_name()

# assert
assert result == f"{expected}-metrics"


def test__get_sink__returns_stdout_sink():
# arrange
env = LocalEnvironment()

# act
result = env.get_sink()

# assert
assert isinstance(result, StdoutSink)
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from importlib import reload

from aws_embedded_metrics import config
from aws_embedded_metrics.sinks.lambda_sink import LambdaSink
from aws_embedded_metrics.sinks.stdout_sink import StdoutSink
from aws_embedded_metrics.logger.metrics_context import MetricsContext
from faker import Faker
from unittest.mock import patch
Expand All @@ -14,9 +14,10 @@ def test_accept_writes_to_stdout(capfd):
# arrange
reload(config)

sink = LambdaSink()
sink = StdoutSink()
context = MetricsContext.empty()
context.meta["Timestamp"] = 1
context.put_metric("Dummy", 1)

# act
sink.accept(context)
Expand All @@ -25,7 +26,8 @@ def test_accept_writes_to_stdout(capfd):
out, err = capfd.readouterr()
assert (
out
== '{"_aws": {"Timestamp": 1, "CloudWatchMetrics": [{"Dimensions": [], "Metrics": [], "Namespace": "aws-embedded-metrics"}]}}\n'
== '{"_aws": {"Timestamp": 1, "CloudWatchMetrics": [{"Dimensions": [], "Metrics": [{"Name": "Dummy", "Unit": "None"}], '
'"Namespace": "aws-embedded-metrics"}]}, "Dummy": 1}\n'
)


Expand All @@ -34,7 +36,7 @@ def test_accept_writes_multiple_messages_to_stdout(mock_serializer, capfd):
# arrange
expected_messages = [fake.word() for _ in range(10)]
mock_serializer.serialize.return_value = expected_messages
sink = LambdaSink(serializer=mock_serializer)
sink = StdoutSink(serializer=mock_serializer)
context = MetricsContext.empty()
context.meta["Timestamp"] = 1

Expand Down