-
Notifications
You must be signed in to change notification settings - Fork 39
Add LocalEnvironment using stdout #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# Copyright 2019 Amazon.com, Inc. or its affiliates. | ||
# Licensed under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from aws_embedded_metrics.config import get_config | ||
from aws_embedded_metrics.environment import Environment | ||
from aws_embedded_metrics.logger.metrics_context import MetricsContext | ||
from aws_embedded_metrics.sinks import Sink | ||
from aws_embedded_metrics.sinks.stdout_sink import StdoutSink | ||
from typing import Optional | ||
|
||
Config = get_config() | ||
|
||
|
||
class LocalEnvironment(Environment): | ||
def __init__(self) -> None: | ||
self.sink: Optional[Sink] = None | ||
|
||
async def probe(self) -> bool: | ||
return False | ||
|
||
def get_name(self) -> str: | ||
return Config.service_name or "Unknown" | ||
|
||
def get_type(self) -> str: | ||
return Config.service_type or "Unknown" | ||
|
||
def get_log_group_name(self) -> str: | ||
return Config.log_group_name or f"{self.get_name()}-metrics" | ||
|
||
def configure_context(self, context: MetricsContext) -> None: | ||
pass | ||
|
||
def get_sink(self) -> Sink: | ||
if self.sink is None: | ||
self.sink = StdoutSink() | ||
return self.sink |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
from aws_embedded_metrics import config | ||
from aws_embedded_metrics.environment.local_environment import LocalEnvironment | ||
from aws_embedded_metrics.sinks.stdout_sink import StdoutSink | ||
import pytest | ||
from faker import Faker | ||
|
||
Config = config.get_config() | ||
fake = Faker() | ||
|
||
|
||
@pytest.mark.asyncio | ||
async def test_probe_always_returns_false(): | ||
# arrange | ||
env = LocalEnvironment() | ||
|
||
# act | ||
result = await env.probe() | ||
|
||
# assert | ||
assert result is False | ||
|
||
|
||
def test_get_name_returns_unknown_if_not_specified(): | ||
# arrange | ||
env = LocalEnvironment() | ||
Config.service_name = None | ||
|
||
# act | ||
result = env.get_name() | ||
|
||
# assert | ||
assert result == "Unknown" | ||
|
||
|
||
def test_get_type_returns_unknown_if_not_specified(): | ||
# arrange | ||
env = LocalEnvironment() | ||
Config.service_type = None | ||
|
||
# act | ||
result = env.get_type() | ||
|
||
# assert | ||
assert result == "Unknown" | ||
|
||
|
||
def test_get_name_returns_name_if_configured(): | ||
# arrange | ||
expected_name = fake.word() | ||
env = LocalEnvironment() | ||
Config.service_name = expected_name | ||
|
||
# act | ||
result = env.get_name() | ||
|
||
# assert | ||
assert result == expected_name | ||
|
||
|
||
def test__get_type__returns_type_if_configured(): | ||
# arrange | ||
expected_type = fake.word() | ||
env = LocalEnvironment() | ||
Config.service_type = expected_type | ||
|
||
# act | ||
result = env.get_type() | ||
|
||
# assert | ||
assert result == expected_type | ||
|
||
|
||
def test__get_log_group_name__returns_log_group_if_configured(): | ||
# arrange | ||
expected = fake.word() | ||
env = LocalEnvironment() | ||
Config.log_group_name = expected | ||
|
||
# act | ||
result = env.get_log_group_name() | ||
|
||
# assert | ||
assert result == expected | ||
|
||
|
||
def test__get_log_group_name__returns_service_name_metrics_if_not_configured(): | ||
# arrange | ||
expected = fake.word() | ||
env = LocalEnvironment() | ||
Config.service_name = expected | ||
Config.log_group_name = None | ||
|
||
# act | ||
result = env.get_log_group_name() | ||
|
||
# assert | ||
assert result == f"{expected}-metrics" | ||
|
||
|
||
def test__get_sink__returns_stdout_sink(): | ||
# arrange | ||
env = LocalEnvironment() | ||
|
||
# act | ||
result = env.get_sink() | ||
|
||
# assert | ||
assert isinstance(result, StdoutSink) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍