Skip to content

Disallow duplicate dimension sets #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 22, 2022
Merged

Disallow duplicate dimension sets #85

merged 6 commits into from
Aug 22, 2022

Conversation

Stephen-Bao
Copy link
Contributor

Issue #, if available:
#83

Description of changes:
This is the fix for preventing duplicate dimension set in python library associated with related issues in other libraries described in #83.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Stephen-Bao Stephen-Bao requested a review from markkuhn August 15, 2022 04:03
@markkuhn markkuhn requested a review from gordonpn August 15, 2022 17:33
markkuhn
markkuhn suggested changes Aug 16, 2022
View reviewed changes
gordonpn
gordonpn requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@gordonpn gordonpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have another test that calls set_dimensions() in between two put_dimensions() calls and verifying the length/values?

put_dimensions()
set_dimensions()
put_dimensions()

@markkuhn markkuhn requested a review from johnjang August 18, 2022 22:41
@markkuhn
Copy link
Contributor

🚀

@markkuhn markkuhn added the bug Something isn't working label Aug 22, 2022
@Stephen-Bao Stephen-Bao merged commit d7e5a1f into master Aug 22, 2022
@gordonpn gordonpn deleted the prevent-dup-dimensions branch August 22, 2022 20:32
@markkuhn markkuhn linked an issue Sep 15, 2022 that may be closed by this pull request
Disallow duplicate dimension sets #83
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordonpn gordonpn gordonpn approved these changes

@markkuhn markkuhn markkuhn approved these changes

@johnjang johnjang Awaiting requested review from johnjang

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow duplicate dimension sets
3 participants
@Stephen-Bao @markkuhn @gordonpn