-
Notifications
You must be signed in to change notification settings - Fork 27
KMSKeyring error handling #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
IMO this is two questions:
For the first question, I would argue that:
The reason for this is explored here[1] for the AWS KMS keyring, and we need to generalize that to the keyring interface. |
What is a "decryption contract?" I don't see that term used or defined in this specification. |
That's a good call out. "Decryption contract" is the shorthand I've started using to refer to the properties that a caller is stating MUST be true through details of the keyring configuration[1]. I described it in the AWS KMS keyring spec because we had a pressing need, but we need to generalize this concept into the spec somewhere because this is a more general characteristic that all keyrings need to consider. |
Closing in favor of #165 |
The multi keyring will "notify" an error if a child keyring errors
and no other child keyring is able to decrypt and encrypted data key.
The KMSKeyring should do the same thing,
even if it is in
discovery
mode.See: aws/aws-encryption-sdk-javascript#212
Currently the C ESDK does not "notify" the errors if in
discovery
mode.The text was updated successfully, but these errors were encountered: