-
Notifications
You must be signed in to change notification settings - Fork 26
chore: update for mrk support in keystore #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
before approving, let's get someone else to review and change the PR title to be compliant with semantic commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ajewellamz Did the "no admin actions" change get in here? |
Discovery and chainging the region of a KMS key on decrypt do not mutate the customer input. This aligns with customer intent. Further the behavior of the code is to use the provided key directly #267 underspecified how branch keys should be created so this PR rolls back that change.
Discovery and changing the region of a KMS key on decrypt do not mutate the customer input. This aligns with customer intent. Further the behavior of the code is to use the provided key directly #267 underspecified how branch keys should be created so this PR rolls back that change.
Discovery and changing the region of a KMS key on decrypt do not mutate the customer input. This aligns with customer intent. Further the behavior of the code is to use the provided key directly #267 underspecified how branch keys should be created so this PR rolls back that change.
Discovery and changing the region of a KMS key on decrypt do not mutate the customer input. This aligns with customer intent. Further the behavior of the code is to use the provided key directly #267 underspecified how branch keys should be created so this PR rolls back that change.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Check any applicable: