Skip to content

feat(Keystore): Introduce additional KMSConfiguration options #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 20, 2024

Conversation

texastony
Copy link
Contributor

Issue #, if available:

Description of changes:
This PR is logically equivalent #270 .
However, @seebees and @texastony have agreed to merge this PR
and leave #270 open so we can resolve the open issues in it
at a later date.

Thus, this PR will be merged to master when
aws/aws-cryptographic-material-providers-library#316
is merged to mainline.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@texastony texastony requested a review from a team as a code owner May 19, 2024 21:22
@texastony texastony requested a review from seebees May 19, 2024 21:25
Copy link
Contributor

@kessplas kessplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified that the changes are the same as the current state of 270.

@texastony texastony merged commit abdf4ea into master May 20, 2024
@texastony texastony deleted the tony/refactor-keystore-kms-config branch May 20, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants