Skip to content

feat(Caching): Cache across Hierarchy Keyring #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Sep 16, 2024

Conversation

RitvikKapila
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start.
But you need to write more about how the inputs to the SHA are ensured to not collide.
Add content focusing on that.

@RitvikKapila RitvikKapila changed the base branch from tony/feat-cache-across-hierarchy-keyrings to master August 14, 2024 22:11
@RitvikKapila RitvikKapila marked this pull request as ready for review August 15, 2024 20:27
@RitvikKapila RitvikKapila requested a review from a team as a code owner August 15, 2024 20:27
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress!
Great Progress!
More than enough to move on to the implementation.
We may still need to refine the sections on the Cache Formulas.

I need to look at the rendered view...

OK... I just looked at the rendered view...

@RitvikKapila : Format the formulas like we have done else where.
Surround them with 3 `.
i.e:

SHA512(
        SHA512(UTF8Encode(cachingCMM.partitionId))
        + 0x00 
        + SHA512(SerializeEncryptionContext(getEncryptionMaterialsRequest.encryptionContext))
)

That is one element per line,
in a source formatted block.

Comment on lines 234 to 235
This is not practical for a multi-threaded system.
Also, we cannot keep track of these "unique numbers".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this option differ from option 1 because the keystore-id is "unique numbers" that we CAN track?

Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on changes need in framework.
Will review change.md another time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not reviewing the change doc today.

josecorella
josecorella previously approved these changes Sep 14, 2024
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@RitvikKapila RitvikKapila merged commit c1bda2f into master Sep 16, 2024
4 checks passed
@RitvikKapila RitvikKapila deleted the rkapila/feat-cache-across-hierarchy-keyrings branch September 16, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants