-
Notifications
You must be signed in to change notification settings - Fork 26
feat(Caching): Cache across Hierarchy Keyring #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Caching): Cache across Hierarchy Keyring #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start.
But you need to write more about how the inputs to the SHA are ensured to not collide.
Add content focusing on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress!
Great Progress!
More than enough to move on to the implementation.
We may still need to refine the sections on the Cache Formulas.
I need to look at the rendered view...
OK... I just looked at the rendered view...
@RitvikKapila : Format the formulas like we have done else where.
Surround them with 3 `.
i.e:
SHA512(
SHA512(UTF8Encode(cachingCMM.partitionId))
+ 0x00
+ SHA512(SerializeEncryptionContext(getEncryptionMaterialsRequest.encryptionContext))
)
That is one element per line,
in a source formatted block.
This is not practical for a multi-threaded system. | ||
Also, we cannot keep track of these "unique numbers". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't this option differ from option 1 because the keystore-id is "unique numbers" that we CAN track?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on changes need in framework.
Will review change.md
another time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not reviewing the change doc today.
changes/2024-09-13_cache-across-hierarchical-keyrings/change.md
Outdated
Show resolved
Hide resolved
changes/2024-09-13_cache-across-hierarchical-keyrings/background.md
Outdated
Show resolved
Hide resolved
changes/2024-09-13_cache-across-hierarchical-keyrings/background.md
Outdated
Show resolved
Hide resolved
changes/2024-09-13_cache-across-hierarchical-keyrings/change.md
Outdated
Show resolved
Hide resolved
changes/2024-09-13_cache-across-hierarchical-keyrings/change.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Check any applicable: