Skip to content

fix: Names and clarification #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Sep 11, 2024

The encyrption context on hierarchical materials
is all the encryption context,
not only any custom values set by the customer
on branch key creation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

The encyrption context on hierarchical materials
is all the encryption context,
not only any custom values set by the customer
on branch key creation.
@seebees seebees requested a review from a team as a code owner September 11, 2024 17:07
@seebees seebees merged commit c594df9 into master Sep 11, 2024
4 checks passed
@seebees seebees deleted the seebees/storage-name-updates branch September 11, 2024 17:19
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going to look right now, but I do not know if this was the right spec update.

Did anyone run a grep to see where #encryption-context-3 is used?

texastony pushed a commit that referenced this pull request Jun 20, 2025
The encyrption context on hierarchical materials
is all the encryption context,
not only any custom values set by the customer
on branch key creation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants