feat: Make sure that storm caching settings are resonable #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to configure a hierarchical keyring with storm tracking settings that resulted in poor caching performance. If the grace period is greater than the TTL, this results in items being immediately retried.
ajewellamz
reviewed
Sep 12, 2024
ajewellamz
reviewed
Sep 12, 2024
Co-authored-by: seebees <[email protected]>
ajewellamz
approved these changes
Oct 2, 2024
texastony
pushed a commit
that referenced
this pull request
Jun 20, 2025
* feat: Make sure that storm caching settings are reasonable It was possible to configure a hierarchical keyring with storm tracking settings that resulted in poor caching performance. If the grace period is greater than the TTL, this results in items being immediately retried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to configure a hierarchical keyring with storm tracking settings that resulted in
poor caching performance.
If the grace period is greater than the TTL,
this results in items being immediately retried.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Check any applicable: