Corrected --target name in README, added links. #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text was referring to `x86_64-linux` as a target, which is not even a valid value. From what I know, the only valid target is `x86_64-unknown-linux-musl`, so we may just as well say so. I lost at least an hour (novice!) trying to figure it out. Relates to issue #216.
softprops
approved these changes
Jul 14, 2020
|
D'oh, sorry about that! |
davidbarsky
approved these changes
Jul 14, 2020
Veetaha
pushed a commit
to Veetaha/aws-lambda-rust-runtime
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #216
Description of changes:
The text was referring to
x86_64-linuxas a target, which is not even a valid value. From what I know, the only valid target isx86_64-unknown-linux-musl, so we may just as well say so. I lost at least an hour (novice!) trying to figure it out.By submitting this pull request