Skip to content

Use specific commit for pytest and bump pytest-cov #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

joguSD
Copy link
Contributor

@joguSD joguSD commented Aug 26, 2016

Some changes to the cli exposed a bug in the stdin/out capturing feature of pytest. I've opened an upstream pull request to fix this and it has been merged: pytest-dev/pytest#1866. Until this version releases next week, I'll be setting the pytest version to be a specific commit including the bugfix to get tests passing again.

@jamesls @kyleknap

@JordonPhillips
Copy link
Contributor

--    .-""-.
   ) (     )
  (   )   (
     /     )
    (_    _)                     0_,-.__
      (_  )_                     |_.-._/
       (    )                    |_--..\
        (__)                     |__--_/
     |''   ``\                   |
     |        \                  |      /b.
     |         \  ,,,---===?A`\  |  ,==y'
   ___,,,,,---==""\        |M] \ | ;|\ |>
           _   _   \   ___,|H,,---==""""bno,
    o  O  (_) (_)   \ /          _     AWAW/
                     /         _(+)_  dMM/
      \@_,,,,,,---=="   \      \\|//  MW/
--''''"                         ===  d/
                                    //
                                    ,'__________________________
   \    \    \     \               ,/~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         _____    ,'  ~~~   .-""-.~~~~~~  .-""-.
      .-""-.           ///==---   /`-._ ..-'      -.__..-'
            `-.__..-' =====\\\\\\ V/  .---\.
                      ~~~~~~~~~~~~, _',--/_.\  .-""-.
                            .-""-.___` --  \|         -.__..-

@kyleknap
Copy link

🚢 Might be good to put a todo comment on why you comment out 3.0.1 so that we remember, but if it gets quickly updated this should not be an issue.

@joguSD
Copy link
Contributor Author

joguSD commented Aug 26, 2016

I was actually just about to update that comment to the correct version that the fix should be in.

@kyleknap
Copy link

Awesome. 🚢

@joguSD joguSD merged commit 40ade62 into awslabs:master Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants