Skip to content

Commit d864bb4

Browse files
adimuxadimux
adimux
andauthored
correct mistaie in previous commit (#528)
In TF tests, verify that TF version is supported, not pytorch's Co-authored-by: Adam Cherti <[email protected]>
1 parent 7d857c9 commit d864bb4

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

tests/pytorch/test_get_hook.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1+
# Third Party
12
import pytest
23
import torch
34
from numpy import percentile
45
from tests.utils import SagemakerSimulator, Timer, is_running_in_codebuild
56
from torch.utils.smdebug import get_smdebug_hook
67

8+
# First Party
79
from smdebug.core.utils import FRAMEWORK, is_framework_version_supported
810

911

@@ -25,6 +27,7 @@ def test_did_you_forget_to_update_the_supported_framework_version():
2527
f" if you are trying to release sagemaker-debugger for the next version of pytorch ({torch.__version__})."
2628
)
2729

30+
2831
@pytest.mark.skipif(
2932
is_running_in_codebuild() is False,
3033
reason="Microbenchmarking thresholds have been determined only for ci",

tests/tensorflow/keras/test_keras.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def test_did_you_forget_to_update_the_supported_framework_version():
147147
148148
This is just to make you aware of the problem.
149149
"""
150-
if not is_framework_version_supported(FRAMEWORK.PYTORCH):
150+
if not is_framework_version_supported(FRAMEWORK.TENSORFLOW):
151151
raise Exception(
152152
"You are running against an unsupported version of Tensorflow..."
153153
" Please update `smdebug.tensorflow.utils.SUPPORTED_TF_VERSION_THRESHOLD`"

0 commit comments

Comments
 (0)