Skip to content

correct mistaie in previous commit #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

adimux
Copy link
Contributor

@adimux adimux commented Feb 1, 2022

In TF tests, verify that TF version is supported, not pytorch's

Description of changes:

Style and formatting:

I have run pre-commit install && pre-commit run --all-files to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

In TF tests, verify that TF version is supported, not pytorch's
@adimux adimux force-pushed the verify_tf_version_in_tests branch from f7b3d9b to 69d9866 Compare February 1, 2022 19:43
@codecov-commenter
Copy link

Codecov Report

Merging #528 (69d9866) into master (7d857c9) will increase coverage by 8.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   62.87%   71.24%   +8.37%     
==========================================
  Files         127      117      -10     
  Lines       11117    10591     -526     
==========================================
+ Hits         6990     7546     +556     
+ Misses       4127     3045    -1082     
Impacted Files Coverage Δ
smdebug/tensorflow/reductions.py 0.00% <0.00%> (-47.06%) ⬇️
smdebug/tensorflow/keras.py 57.42% <0.00%> (-14.46%) ⬇️
...mdebug/profiler/analysis/notebook_utils/heatmap.py 0.00% <0.00%> (-13.01%) ⬇️
smdebug/profiler/utils.py 65.43% <0.00%> (-11.73%) ⬇️
smdebug/xgboost/hook.py 0.00% <0.00%> (-8.43%) ⬇️
smdebug/core/logger.py 70.83% <0.00%> (-5.56%) ⬇️
smdebug/profiler/profiler_config_parser.py 83.51% <0.00%> (-3.73%) ⬇️
smdebug/profiler/analysis/python_stats_reader.py 94.28% <0.00%> (-1.43%) ⬇️
smdebug/profiler/python_profiler.py 83.33% <0.00%> (-0.93%) ⬇️
smdebug/pytorch/hook.py 77.88% <0.00%> (-0.65%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d857c9...69d9866. Read the comment docs.

@Roshrini Roshrini merged commit d864bb4 into master Feb 1, 2022
@Roshrini Roshrini deleted the verify_tf_version_in_tests branch February 1, 2022 22:41
atqy pushed a commit to atqy/sagemaker-debugger that referenced this pull request Aug 12, 2022
In TF tests, verify that TF version is supported, not pytorch's

Co-authored-by: Adam Cherti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants