fix: add missing type for allowAbsoluteUrls #6818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonsaayman Haha, I guess it wasn't that nicely done. I have updated it and ran all the tests this time |
i see a syntax issue haha, the workflow would have caught this |
|
Hi, @StefanBRas! This PR has been published in v1.8.3 release. Thank you for your contribution ❤️! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
allowAbsoluteUrlsfield to the types and to the type tests.Fixes #6817.
It's my first PR to axios so I don't really know that much about how types are generated it. Hoping it's enough with changing it these two places.