Fix off-by-one error with fast clahe#80
Merged
axtimwalde merged 1 commit intoaxtimwalde:masterfrom Jun 9, 2025
Merged
Conversation
Contributor
Author
|
Thanks, @axtimwalde ! You might want to hold off deploying if you planned on doing that, since I'm still working on another aspect of the CLAHE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor off-by-one error of the "fast CLAHE" algorithm: the last column and row were not corrected before. I noticed this when correcting and reslicing a stack, which resulted in the last slice not being corrected.
This is a zoom-in of the lower right corner of the 'boats' image, treated with fast CLAHE (left) and normal CLAHE (right). Note the dark right and bottom pixels.
To reproduce, execute this:
Tagging @axtimwalde and @StephanPreibisch for discussion.