Skip to content

Sync fork 202505 v2 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
May 25, 2025
Merged

Sync fork 202505 v2 #60

merged 45 commits into from
May 25, 2025

Conversation

ariyanki
Copy link

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #xxx

What is in this change?

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

KPCOFGS and others added 30 commits May 7, 2025 09:16
* Update README.zh-CN.md

* Update README.zh-CN.md

* Update README.zh-CN.md

* Update README.md
* Update README.zh-CN.md

* Update README.md

* Update README.md

---------

Co-authored-by: Timothy Carambat <[email protected]>
* Update README.zh-CN.md

* Update README.zh-CN.md
* wip system prompt history sidebar ui

* lint

* backend/frontend implementation for prompt history wip

* lint

* rework ui

* add delete menu and delete chat history by id

* lint

* ref for menu button

* reorganize components + light mode styles

* lint

* UI refactor

* backend refactor

* remove unused import

* add border-none to all buttons

* fix spacing on dots 3 icon button

* add window to confirm

* add english translations

* normalize translations

* lin

* patch store logic

* sticky header

---------

Co-authored-by: timothycarambat <[email protected]>
* Update common.js

* linting

---------

Co-authored-by: timothycarambat <[email protected]>
* Update common.js

* Update common.js

* lint

---------

Co-authored-by: timothycarambat <[email protected]>
* Implemented spellcheck toggle in Settings

* ran yarn lint

* reduce read complexity for appearance spellcheck
lint

---------

Co-authored-by: timothycarambat <[email protected]>
update:WorkspaceChat ChatContainer PromptInput

Co-authored-by: Timothy Carambat <[email protected]>
* Update README.zh-CN.md

* Update common.js
* PGVector support for vector db storage

* forgot files

* comments

* dev build

* Add ENV connection and table schema validations for vector table
add .reset call to drop embedding table when changing the AnythingLLM embedder
update instrutions
Add preCheck error reporting in UpdateENV
add timeout to pg connection

* update setup

* update README

* update doc
* corrected toggle server toast text

* reordered code for readability

* reordered code for readability

* ran yarn lint

* reordered code for readability

* ran yarn lint
* Update common.js

* Update README.md

* Update common.js

* Update README.md

* linting

---------

Co-authored-by: timothycarambat <[email protected]>
* add obsidian vault data connector

* lint

* add english translations

* normalize translations

* improve file parser and reader

---------

Co-authored-by: timothycarambat <[email protected]>
* Fix typos

* language

---------

Co-authored-by: timothycarambat <[email protected]>
* update light mode designs for system prompt history

* lint

---------

Co-authored-by: Timothy Carambat <[email protected]>
* Add context window finder from litellm maintained list
apply to all cloud providers, have client cache for 3 days

* docker container bootup warning

* update invalid ENV warning

* rebased with current HEAD

* update newline printing
* Add context window finder from litellm maintained list
apply to all cloud providers, have client cache for 3 days

* linting
* fix ux for create api key and create invite

* lint

---------

Co-authored-by: Timothy Carambat <[email protected]>
timothycarambat and others added 15 commits May 14, 2025 16:05
* remove summarization from web-scraping flow block

* add option to enable/disable summarization in web-scraping block

* change layout
summarize default to true (was the normal prior)

---------

Co-authored-by: Timothy Carambat <[email protected]>
* wip

* implment conditional streaming

* no bench
* Disable message send while content is embedding

* opacity

* normalize langs

* remove console log

---------

Co-authored-by: shatfield4 <[email protected]>
* Update README.zh-CN.md

* Update common.js

* Update common.js
@ariyanki ariyanki requested review from Copilot and lohawk-azalea May 25, 2025 00:02
@lohawk-azalea lohawk-azalea merged commit 7341d14 into master May 25, 2025
1 check passed
@lohawk-azalea lohawk-azalea deleted the sync-fork-202505-v2 branch May 25, 2025 00:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR syncs the fork with upstream (202505 v2), adds Obsidian vault support, introduces a package‐version verification script with CI, and applies various typo fixes and documentation updates.

  • Added Obsidian connector image and backend vault‐loading extension/endpoints
  • Introduced verifyPackageVersions.mjs and corresponding GitHub Action to enforce dependency version parity
  • Fixed typos in docs/README, updated sponsor and CI workflows

Reviewed Changes

Copilot reviewed 114 out of 117 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
frontend/src/components/Modals/ManageWorkspace/DataConnectors/Connectors/DrupalWiki/index.jsx Typo fix: “seperated” → “separated”
frontend/src/components/LLMSelection/OllamaLLMOptions/index.jsx Removed initialAuthToken, added masked defaultValue for token input
frontend/src/components/LLMSelection/DPAISOptions/index.jsx New DellProAIStudioOptions component for Dell Pro AI Studio
frontend/src/components/DataConnectorOption/media/index.js Added Obsidian connector image
extras/scripts/verifyPackageVersions.mjs New script to verify package versions between server and collector
collector/utils/files/index.js Exported documentsFolder constant
collector/utils/extensions/RepoLoader/GitlabRepo/index.js Reformatted ternary for wiki description
collector/utils/extensions/ObsidianVault/index.js New Obsidian vault loader extension
collector/extensions/index.js Registered Obsidian vault endpoint
cloud-deployments/gcp/deployment/DEPLOY.md Fixed “one setup” → “once setup” typo
cloud-deployments/digitalocean/terraform/DEPLOY.md Fixed “one setup” → “once setup” typo
cloud-deployments/aws/cloudformation/DEPLOY.md Fixed “one setup” → “once setup” typo
README.md Various typo corrections, added PGVector, sponsors, section count
.github/workflows/sponsors.yaml Added sponsors README generation workflow
.github/workflows/dev-build.yaml Updated dev-build branch filter
.github/workflows/check-package-versions.yaml New workflow to run package version checker
Files not reviewed (3)
  • collector/package.json: Language not supported
  • docker/.env.example: Language not supported
  • docker/docker-entrypoint.sh: Language not supported
Comments suppressed due to low confidence (2)

frontend/src/components/LLMSelection/OllamaLLMOptions/index.jsx:21

  • Removing initialAuthToken from the auto-discovery hook may prevent the saved token from being used during endpoint discovery. Re-include initialAuthToken: settings?.OllamaLLMAuthToken in the hook options.
    //    initialAuthToken: settings?.OllamaLLMAuthToken,

.github/workflows/check-package-versions.yaml:36

  • The expression if: failure() isn’t a valid GitHub Actions syntax. Use if: ${{ failure() }} or rely on default continue-on-error settings.
        if: failure()

Comment on lines +211 to 214
defaultValue={
settings?.OllamaLLMAuthToken ? "*".repeat(20) : ""
}
value={authTokenValue.value}
Copy link
Preview

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using defaultValue on a controlled input (with value prop) has no effect. Consider initializing the state in your hook or using a placeholder instead of defaultValue.

Suggested change
defaultValue={
settings?.OllamaLLMAuthToken ? "*".repeat(20) : ""
}
value={authTokenValue.value}
value={authTokenValue.value || (settings?.OllamaLLMAuthToken ? "*".repeat(20) : "")}

Copilot uses AI. Check for mistakes.

<option
key={model.id}
value={model.id}
selected={settings.DellProAiStudioModelPref === model.id}
Copy link
Preview

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline selected attributes on <option> can cause React warnings. It’s better to control the <select> by giving it a value prop tied to state or settings.

Suggested change
selected={settings.DellProAiStudioModelPref === model.id}

Copilot uses AI. Check for mistakes.

Comment on lines +6 to +7
* The folder where documents are stored to be stored when
* processed by the collector.
Copy link
Preview

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment reads “stored to be stored,” which is redundant. Consider rephrasing to something like “The folder where documents are placed for processing by the collector.”

Suggested change
* The folder where documents are stored to be stored when
* processed by the collector.
* The folder where documents are placed for processing by the collector.

Copilot uses AI. Check for mistakes.

@@ -180,6 +181,27 @@ function extensions(app) {
return;
}
);

app.post(
Copy link
Preview

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] You’ve added a new /ext/obsidian/vault endpoint—consider updating any API documentation or OpenAPI specs so consumers know about this new route.

Copilot uses AI. Check for mistakes.

@@ -6,7 +6,7 @@ concurrency:

on:
push:
branches: ['2237-auto-stt-submit-preference'] # put your current branch to create a build. Core team only.
branches: ['warn-bad-docker-command'] # put your current branch to create a build. Core team only.
Copy link
Preview

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The dev-build workflow is hard-coded to run only on warn-bad-docker-command. This may be out of date—consider parameterizing or documenting this filter to avoid dangling configurations.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants