This repository was archived by the owner on May 19, 2018. It is now read-only.
Alow regex after "of" in for(...of...)#579
Merged
existentialism merged 2 commits intobabel:masterfrom Aug 3, 2017
nicolo-ribaudo:for-of-regex
Merged
Alow regex after "of" in for(...of...)#579existentialism merged 2 commits intobabel:masterfrom nicolo-ribaudo:for-of-regex
existentialism merged 2 commits intobabel:masterfrom
nicolo-ribaudo:for-of-regex
Conversation
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 98.14% 98.15% +<.01%
==========================================
Files 22 22
Lines 3674 3677 +3
Branches 1024 1025 +1
==========================================
+ Hits 3606 3609 +3
Misses 25 25
Partials 43 43
Continue to review full report at Codecov.
|
Member
|
This looks fine, but we may also want to ref acorn's fix, as there's also another case of handling contextual yield. |
Member
Author
|
The bug with yield fixed by that commit already works in Babylon: https://astexplorer.net/#/gist/806e25352b11e858e13a0ccaf722816f/latest |
existentialism
approved these changes
Aug 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially tried to set
this.state.exprAllowedin the parser, after eating the "of" word (here), but then I decided to fix this bug directly in context.js.This fix, teorically, has a "bug": in
for (a++ of /foo/g);, the regex is parsed as a division because++can be followed by an expression. In practice this can't happen, becausea++is not a valid assignment target and thus babel throws before encountering/.