This repository was archived by the owner on May 19, 2018. It is now read-only.
white lists getter and setter acceseors for having stage-2 decorators (#756)#766
Merged
danez merged 1 commit intobabel:masterfrom Oct 31, 2017
Merged
Conversation
- adds `get` and `set` kind in addition to `method` to the list of allowed class members for having a decorator, - adds tests for this two cases (decorator + set and decorator + get)
Contributor
Author
Member
|
Thank you very much for your first pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getandsetkind in addition tomethodto the list of allowed class members for having a decorator,For stage 2 decorators, the
parseClassBodychecks if the decorator is attached to a class method. aka itskindismethod. And throws an error if not.commit af08e92 adds
setandgetto the class members which are allowed to have a decorator. (extends the check tokind === set || getin addition tomethod