patch: Add support to search DUTs in multiple fleets #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
Member
Author
|
Good to be checked out now, I tried to be smart about by using map function for the array but for some reason it's just not working out. So, went with this solution which helps us eliminate any need of a IF statement to get the job done. Give it a go @rcooke-warwick |
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
vipulgupta2048
force-pushed
the
vipul/multiple-apps
branch
from
fba8699 to
da44298
Compare
Member
Author
|
Closin in favor #1059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't tested it, since I needed another fleet to test this in but I am confident it should work fine.
To search in more than one fleet for potential workers, create an array of fleet slugs in the worker object. That's the solution. Again though, I need to test this before getting it through and probably it would be better if we could write tests for it as well.
Context: https://balena.zulipchat.com/#narrow/stream/345889-loop.2Fbalena-os/topic/London.20test.20rig.20EOL/near/308002887
Signed-off-by: Vipul Gupta (@vipulgupta2048) [email protected]