Fix duplicate $td$ typedesc var for const type alias - #44653
Open
senuriwick wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
senuriwick
marked this pull request as ready for review
July 10, 2026 03:54
senuriwick
requested review from
MaryamZi,
gimantha,
hasithaa and
sameerajayasoma
as code owners
July 10, 2026 03:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Compiling a module containing a type definition that aliases directly to a constant fails with a generic, unhelpful error.
Fixes #44586
Approach
The fix tracks generated typedesc variable names per module in
createTypedescVariableand skips creation if a variable with that name already exists, with the tracking reset per module (not per type-definition or per statement list, so as not to disturb the existing, narrowertypedescListbatching) deduping by generated name rather than byBTypeobject identity, since the two colliding types are structurally related but not the same Java object.Samples
Remarks
The current fix dedupes by generated name within a module. This mirrors an existing name-based guard in the same method, but in principle two distinct types could theoretically share a generated name (e.g. via import-shadowing of simple names). This wasn't observed as an issue and is considered out of scope for this fix; flagging for awareness.
Check List