systemcontract: optimize gas cost #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
txhsl
changed the title
txhsl
changed the title
txhsl
requested review from
chenquanyu and
passer-byzhang
and removed request for
chenquanyu
txhsl
force-pushed
the
governance-gas-optimize
branch
from
86f4780 to
62bdbbe
Compare
Collaborator
passer-byzhang
left a comment
passer-byzhang
left a comment
There was a problem hiding this comment.
It seems like fixed except Caching Arrays Length in Loops and Increase Operation Optimization
txhsl
added a commit
that referenced
this pull request
May 21, 2024
* index some event parameters * update solidity compiler version * systemcontract: governance unit tests (#210) * update gitignore * init hardhat project * first ut * systemcontract: add candidate management ut and getter check (#211) * systemcontract: use customized error library (#209) * systemcontract: use customized error library * update existing ut --------- Co-authored-by: belane <[email protected]>
Contributor
Author
|
This well also close #207, since other unit tests has been already merged. |
chenquanyu
reviewed
May 28, 2024
chenquanyu
reviewed
May 29, 2024
txhsl
changed the title
chenquanyu
approved these changes
May 29, 2024
txhsl
added a commit
that referenced
this pull request
May 30, 2024
* index some event parameters * update solidity compiler version * systemcontract: governance unit tests (#210) * update gitignore * init hardhat project * first ut * systemcontract: add candidate management ut and getter check (#211) * systemcontract: use customized error library (#209) * systemcontract: use customized error library * update existing ut * systemcontract: add policy unit tests (#214) * systemcontract: add ut about reward distribution and fix several ut (#215) * systemcontract: optimize gas cost (#195) * systemcontract: optimize gas cost --------- Co-authored-by: belane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #201, #205, #207. Done, also fixed several potential bugs of
GovernanceVote.