-
Notifications
You must be signed in to change notification settings - Fork 0
systemcontract: change register fee and exit fee rate #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AnnaShaleva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 50% is really a lot, this logic seems to be imbalanced a bit with this value. Do you have a reason of why the charge is so large?
b6873ef to
2844e04
Compare
Well, the code expression of 50% seems quite rude, so I changed it a bit. Let me describe the background first.
How about now? I declare the exit fee as a fixed value. |
roman-khimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it that much different from N3 "pay 1000 GAS and never worry again)" model then?
AnnaShaleva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, the previous rate-based way was more preferable to me because fee is always proportional to the deposit which seems to be honest and protective from DoS for every deposit value. The question from my side was why 50%. But from your answer I see that it's a necessity, thus may be it's OK to keep 50%.
3163f36 to
076447d
Compare
To have the same thing as N3 “pay 1000 GAS and never worry again” model, I will have to change the register and exit logic here. But I don't expect that after audit, especially closely before mainnet. |
Make it follow the contract logic adjusted in #275. Signed-off-by: Anna Shaleva <[email protected]>
Relate #247, #236 and #271.
Increase the exit fee rate from 5% to 50%, but decrease the register fee from 20000 GAS to 2000 GAS, which is suggested by @steven1227 for mainnet configuration.
NOTE: Genesis allocation is not updated here.