dBFT: ensure WatchOnly is able to properly handle threshold block signing scheme #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end, there's no functional changes in fact. But decryption is checked and threshold signatures work us expected even for WatchOnly node that only has a shared PublicKey available. Here's an example of logs for WatchOnly after NeoXAMEV fork is enabled.
@txhsl, please, take a look, this PR will be useful for #332 testing. I generated antimev keystore for WatchOnly node and setup it manually (if needed, then I can share the code, it's based on our TPKE tests), so that WatchOnly keystore doesn't have private key share, and only has access to global public key.