Skip to content

chore: updated documentation and fixed typos #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: updated documentation and fixed typos #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions sepolia/2024-09-11-update-proposer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ message hash to approve on your Ledger then verify completion:
3. Validate and extract domain hash and message hash to approve.


#### 3.1. Validate integrity of the simulation.
#### 3.1 Validate integrity of the simulation.

Make sure you are on the "Overview" tab of the tenderly simulation, to
validate integrity of the simulation, we need to check the following:
Expand All @@ -65,11 +65,11 @@ validate integrity of the simulation, we need to check the following:
4. "Success" with a green check mark


#### 3.2. Validate correctness of the state diff.
#### 3.2 Validate correctness of the state diff.

Now click on the "State" tab. Verify that:

1. Verify that the nonce is incremented for the Incident Multisig under the "GnosisSafeProxy" at address `0x0fe884546476dDd290eC46318785046ef68a0BA9`. We should see the nonce increment from 5 to 6:
1. Verify that the nonce is incremented for the Incident Multisig under the "SafeProxy" at address `0x0fe884546476dDd290eC46318785046ef68a0BA9`. We should see the nonce increment from 5 to 6:

```
Key: 0x0000000000000000000000000000000000000000000000000000000000000005
Expand All @@ -85,7 +85,7 @@ Before: 0x000000000000000000000000ccefe451048eaa7df8d0d709be3aa30d565694d2
After: 0x000000000000000000000000<NEW PERMISSIONED GAME ADDRESS>
```

#### 3.3. Extract the domain hash and the message hash to approve.
#### 3.3 Extract the domain hash and the message hash to approve.

Now that we have verified the transaction performs the right
operation, we need to extract the domain hash and the message hash to
Expand Down Expand Up @@ -172,7 +172,7 @@ message hash to approve on your Ledger then verify completion:
4. Validate that the transaction completed successfully


#### 3.1. Validate integrity of the simulation.
#### 3.1 Validate integrity of the simulation.

Make sure you are on the "Overview" tab of the tenderly simulation, to
validate integrity of the simulation, we need to check the following:
Expand All @@ -186,11 +186,11 @@ validate integrity of the simulation, we need to check the following:
4. "Success" with a green check mark


#### 3.2. Validate correctness of the state diff.
#### 3.2 Validate correctness of the state diff.

Now click on the "State" tab. Verify that:

1. Verify that the nonce is incremented for the Incident Multisig under the "GnosisSafeProxy" at address `0x0fe884546476dDd290eC46318785046ef68a0BA9`:
1. Verify that the nonce is incremented for the Incident Multisig under the "SafeProxy" at address `0x0fe884546476dDd290eC46318785046ef68a0BA9`:

```
Key: 0x0000000000000000000000000000000000000000000000000000000000000005
Expand All @@ -206,14 +206,14 @@ Before: 0x000000000000000000000000<NEW PERMISSIONED GAME ADDRESS>
After: 0x000000000000000000000000ccefe451048eaa7df8d0d709be3aa30d565694d2
```

#### 3.3. Extract the domain hash and the message hash to approve.
#### 3.3 Extract the domain hash and the message hash to approve.

Now that we have verified the transaction performs the right
operation, we need to extract the domain hash and the message hash to
approve.

Go back to the "Overview" tab, and find the
`GnosisSafe.checkSignatures` call. This call's `data` parameter
`Safe.checkSignatures` call. This call's `data` parameter
contains both the domain hash and the message hash that will show up
in your Ledger.

Expand Down Expand Up @@ -281,4 +281,4 @@ congrats, you are done!

> [!IMPORTANT] IN THE EVENT WE NEED TO PERFORM ROLLBACK
> Repeat the above, but replace the signatures with the signed
> rollback signatures collected, the call `make execute-rollback`
> rollback signatures collected, the call `make execute-rollback`